forked from qodo-benchmark/aspnetcore
-
Notifications
You must be signed in to change notification settings - Fork 0
Ensure SSL_CERT_DIR messages are always shown and check for existing value #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomerqodo
wants to merge
6
commits into
coderabbit_combined_20260121_qodo_grep_cursor_copilot_base_ensure_ssl_cert_dir_messages_are_always_shown_and_check_for_existing_value_pr82
Choose a base branch
from
coderabbit_combined_20260121_qodo_grep_cursor_copilot_head_ensure_ssl_cert_dir_messages_are_always_shown_and_check_for_existing_value_pr82
base: coderabbit_combined_20260121_qodo_grep_cursor_copilot_base_ensure_ssl_cert_dir_messages_are_always_shown_and_check_for_existing_value_pr82
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−10
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8132afe
Improve the SSL_CERT_DIR messaging on Unix systems.
danegsta 720d95c
Use critical for log level filter
danegsta 1ca0ffe
Update src/Shared/CertificateGeneration/UnixCertificateManager.cs
danegsta ccdc5af
Update src/Shared/CertificateGeneration/CertificateManager.cs
danegsta 86ee07c
Treat invalid SSL_CERT_DIR as a partial success during trust
danegsta c52b13e
update pr
tomerqodo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Path comparison uses display string with unexpanded
$HOMEplaceholder.prettyCertDirmay contain the literal string"$HOME"(set at lines 354-356 for display purposes).Path.GetFullPath()does not expand shell variables—it treats$HOMEas a literal directory component, producing an incorrect path like/cwd/$HOME/.aspnet/dev-certs/trustrather than/home/user/.aspnet/dev-certs/trust.This causes the comparison against
SSL_CERT_DIRentries to always fail when it should succeed.🐛 Proposed fix: use the actual path for comparison
var existingSslCertDir = Environment.GetEnvironmentVariable(OpenSslCertificateDirectoryVariableName); if (!string.IsNullOrEmpty(existingSslCertDir)) { var existingDirs = existingSslCertDir.Split(Path.PathSeparator); - var certDirFullPath = Path.GetFullPath(prettyCertDir); + var certDirFullPath = Path.GetFullPath(certDir); var isCertDirIncluded = existingDirs.Any(dir =>📝 Committable suggestion
🤖 Prompt for AI Agents