[release/10.0] Source code updates from dotnet/dotnet #16
Conversation
WalkthroughThis PR updates NuGet package sources and dependency versions across configuration files. It bumps multiple Microsoft DotNet tooling packages from beta 26055.111 to 26056.115, updates NuGet components to a newer RC version, and modifies a test file with infrastructure and quarantine annotations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/Components/test/E2ETest/ServerRenderingTests/RedirectionTest.cs`:
- Around line 112-116: The test's navigation call is incorrect: replace the
Browser.Navigate().Forward() invocation with Browser.Navigate().Back() so the
test goes back in history to the original "Redirections" page; update the call
where Browser.Navigate().Forward() appears (the surrounding assertions using
Browser.Equal(() => _originalH1Element.Text) and
Assert.EndsWith("/subdir/redirect", Browser.Url) should remain unchanged).
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
NuGet.configeng/Version.Details.propseng/Version.Details.xmlglobal.jsonsrc/Components/test/E2ETest/ServerRenderingTests/RedirectionTest.cs
🔇 Additional comments (9)
global.json (1)
29-32: SDK version updates look consistent.All three MSBuild SDK versions are updated to
10.0.0-beta.26056.115in sync, matching the corresponding entries ineng/Version.Details.propsandeng/Version.Details.xml.NuGet.config (1)
5-8: Package source update is consistent with dependency flow.The new feed key
darc-pub-dotnet-dotnet-10596ebcorrectly corresponds to the updated Sha (10596eb13c79f38d547565beb273458d0c832bf8) ineng/Version.Details.xml. This is standard Maestro dependency flow automation.src/Components/test/E2ETest/ServerRenderingTests/RedirectionTest.cs (2)
8-9: New test infrastructure imports added.The new
usingstatements forMicrosoft.AspNetCore.InternalTestingandMicrosoft.VisualStudio.TestTools.UnitTestingare needed for the[QuarantinedTest]and[TestMethod]attributes used later in the file.
32-34: Navigation timing adjusted.The
Navigatecall is now placed afterBrowser.Exists(By.TagName("h1"))locates the element. This ensures_originalH1Elementis captured before navigation, which aligns with how subsequent tests use it.eng/Version.Details.props (2)
12-18: SDK package versions updated consistently.All Microsoft.DotNet.* build tool packages are updated to
10.0.0-beta.26056.115in sync. These align with the SDK versions inglobal.jsonand dependency entries inVersion.Details.xml.
47-72: Servicing and NuGet package versions updated.The servicing packages (
*-servicing.26056.115) and NuGet packages (7.0.2-rc.5715) are updated consistently. The version suffixes (26056.115 and rc.5715) align with corresponding entries ineng/Version.Details.xml.eng/Version.Details.xml (3)
11-11: Source metadata updated.The Source block's Sha and BarId are updated to reflect the new dotnet/dotnet commit. The Sha prefix (
10596eb) matches the NuGet.config feed key.
361-392: Toolset dependencies updated consistently.All toolset dependencies from dotnet/dotnet are updated to the new versions and Sha in sync:
Microsoft.NETCore.Platforms:10.0.3-servicing.26056.115Microsoft.DotNet.Arcade.Sdkand related:10.0.0-beta.26056.115These match the corresponding entries in
Version.Details.propsandglobal.json.
443-454: NuGet package versions updated.The NuGet packages (
NuGet.Frameworks,NuGet.Packaging,NuGet.Versioning) are updated to7.0.2-rc.5715with the new Sha. Note these are marked withLabel="Manual"but are still updated here—this is expected as they follow the dotnet/dotnet dependency flow.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| // See that 'back' takes you to the place from before the redirection | ||
| Browser.Navigate().Back(); | ||
| Browser.Navigate().Forward(); | ||
| Browser.Equal("Redirections", () => _originalH1Element.Text); | ||
| Assert.EndsWith("/subdir/redirect", Browser.Url); | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cd src/Components/test/E2ETest/ServerRenderingTests && wc -l RedirectionTest.csRepository: qodo-benchmark/aspnetcore-combined-coderabbit
Length of output: 111
🏁 Script executed:
cd src/Components/test/E2ETest/ServerRenderingTests && cat -n RedirectionTest.cs | sed -n '100,130p'Repository: qodo-benchmark/aspnetcore-combined-coderabbit
Length of output: 1939
🏁 Script executed:
cd src/Components/test/E2ETest/ServerRenderingTests && cat -n RedirectionTest.cs | sed -n '40,60p'Repository: qodo-benchmark/aspnetcore-combined-coderabbit
Length of output: 1277
🏁 Script executed:
cd src/Components/test/E2ETest/ServerRenderingTests && cat -n RedirectionTest.cs | sed -n '70,90p'Repository: qodo-benchmark/aspnetcore-combined-coderabbit
Length of output: 1346
🏁 Script executed:
cd src/Components/test/E2ETest/ServerRenderingTests && cat -n RedirectionTest.cs | sed -n '130,180p'Repository: qodo-benchmark/aspnetcore-combined-coderabbit
Length of output: 2962
Fix navigation method: change Forward() to Back().
Line 112 comment correctly states "See that 'back' takes you to the place from before the redirection", but line 113 uses Browser.Navigate().Forward() instead of Browser.Navigate().Back(). This is inconsistent with all other similar tests in this file (lines 51, 80, 141, 169), which use Back() and follow the same test pattern: click a redirection link, assert the destination page, then navigate back to the original page and verify.
The Forward() call appears to be a bug rather than intentional—the test expects to reach the "Redirections" page from the current "Scroll to hash" page, which is the backward direction in browser history, not forward.
🤖 Prompt for AI Agents
In `@src/Components/test/E2ETest/ServerRenderingTests/RedirectionTest.cs` around
lines 112 - 116, The test's navigation call is incorrect: replace the
Browser.Navigate().Forward() invocation with Browser.Navigate().Back() so the
test goes back in history to the original "Redirections" page; update the call
where Browser.Navigate().Forward() appears (the surrounding assertions using
Browser.Equal(() => _originalH1Element.Text) and
Assert.EndsWith("/subdir/redirect", Browser.Url) should remain unchanged).
Benchmark PR from qodo-benchmark#78
Summary by CodeRabbit
Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.