[release/10.0] Source code updates from dotnet/dotnet

[tomerqodo]

Benchmark PR from agentic-review-benchmarks#9

Summary by CodeRabbit

• Chores

  • Updated build infrastructure to macOS 15 and XCode 16.4.0
  • Bumped product dependencies to version 10.0.1
  • Updated .NET SDK and build tool versions
  • Updated NuGet package sources and platform manifests

• Tests

  • Quarantined failing test pending resolution

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR updates the ASP.NET Core build infrastructure from version 10.0.0 to 10.0.1 by bumping all managed dependencies uniformly, upgrading build tooling (macOS and XCode versions), updating NuGet package sources, refactoring MicroBuild temporary directory handling, and adding support for additional internal feed detection.

Changes

Cohort / File(s)	Summary
Build Agent & SDK Configuration .azure/pipelines/jobs/default-build.yml, global.json	Updated macOS image from 13 to 15; XCode from 15.2.0 to 16.4.0; .NET SDK from 10.0.100-rc.1 to 10.0.100-rc.2 and arcade/helix/shared-framework SDK versions from beta.25517.104 to beta.25555.106.
NuGet Package Sources NuGet.config	Replaced package source key darc-pub-dotnet-dotnet-c737522 with darc-pub-dotnet-dotnet-e17b0d0 and updated corresponding URL.
Manifest & Override Files eng/PackageOverrides.txt, eng/PlatformManifest.txt	Added new static manifest files: PackageOverrides.txt enumerates 140+ NuGet packages with uniform version 10.0.0; PlatformManifest.txt defines 143+ platform assembly entries with version mappings.
Version Details & Properties eng/Version.Details.props, eng/Version.Details.xml, eng/Versions.props	Large-scale version bump from 10.0.0 to 10.0.1 across 90+ package properties; AspNetCorePatchVersion changed 0→1; PreReleaseVersionLabel changed rtm→servicing; PreReleaseBrandingLabel updated with dynamic conditions; all corresponding dependency SHA values updated.
NuGet Source Setup Scripts eng/common/SetupNugetSources.ps1, eng/common/SetupNugetSources.sh	Added conditional logic to detect and enable dotnet-eng-internal and dotnet-tools-internal package sources when their corresponding public feeds (dotnet-eng, dotnet-tools) are present.
Build Infrastructure eng/common/core-templates/steps/install-microbuild.yml, eng/targets/ResolveReferences.targets	Refactored MicroBuild output paths from source-directory-based to temporary directory ($(Agent.TempDirectory)); tightened servicing-build error condition (BUILD002) to also check AspNetCorePatchVersion equals "1".
Test Updates src/Components/test/E2ETest/ServerExecutionTests/WebSocketCompressionTests.cs	Added quarantine attribute to EmbeddingServerAppInsideIframe_WithCompressionEnabled_Fails() test.

Estimated Code Review Effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hopping through versions, we bump them with glee,
From 10.0.0 to 10.0.1—servicing spree!
New macOS, new tools, feeds bright and new,
Manifests penned and paths refactored too!
Building aspires as we upgrade the whole crew!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description only contains a reference to a benchmark PR without following the required template structure, which includes summary, detailed description, and issue references.	Add a proper description following the template: include a summary (under 80 chars), detailed description of changes, and reference the related issue in the format 'Fixes #{bug number}'.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title '[release/10.0] Source code updates from dotnet/dotnet' clearly and concisely describes the main change—updating source code from the upstream dotnet/dotnet repository on the release/10.0 branch.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In @.azure/pipelines/jobs/default-build.yml:
- Around line 165-167: Two macOS build steps set xcode-select to
/Applications/Xcode_15.2.0.app but use the label "Use XCode 16.4.0", causing a
version mismatch; locate the steps that contain the lines "script: sudo
xcode-select -s /Applications/Xcode_15.2.0.app/Contents/Developer" and
"displayName: Use XCode 16.4.0" and make them consistent by either changing the
script path to the correct bundle for Xcode 16.4 (e.g.,
/Applications/Xcode_16.4.0.app/Contents/Developer) or updating the displayName
to reflect Xcode 15.2.0, and verify the actual Xcode bundle name available on
the macOS agent before committing.

In `@eng/PackageOverrides.txt`:
- Around line 1-140: The overrides file pins ~140 Microsoft.* and
Microsoft.AspNetCore.* packages to 10.0.0 which masks the intended 10.0.1
servicing updates; remove or update those entries so they no longer force
10.0.0. Edit the overrides list lines that set Microsoft.Extensions.* and
Microsoft.AspNetCore.* (the entries currently equal to "10.0.0") and either
delete those entries entirely or change their versions to "10.0.1" to match
eng/Version.Details.props, then run a restore/build to verify the servicing
updates are applied.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3d63468 and b535239.

📒 Files selected for processing (13)

• .azure/pipelines/jobs/default-build.yml
• NuGet.config
• eng/PackageOverrides.txt
• eng/PlatformManifest.txt
• eng/Version.Details.props
• eng/Version.Details.xml
• eng/Versions.props
• eng/common/SetupNugetSources.ps1
• eng/common/SetupNugetSources.sh
• eng/common/core-templates/steps/install-microbuild.yml
• eng/targets/ResolveReferences.targets
• global.json
• src/Components/test/E2ETest/ServerExecutionTests/WebSocketCompressionTests.cs

🔇 Additional comments (13)

.azure/pipelines/jobs/default-build.yml (1)

105-107: macOS image bump looks consistent.

The macOS-15 image update aligns with the broader tooling upgrade.

Also applies to: 320-323

eng/Versions.props (1)

12-27: Versioning/branding updates look consistent with servicing baseline.

No concerns with these property changes.

eng/targets/ResolveReferences.targets (1)

210-213: Confirm BUILD002 should only apply when patch version is 1.

With the added guard, servicing patches beyond 10.0.1 won’t trigger BUILD002. Please confirm this is intentional for 10.0.2+ servicing releases.

src/Components/test/E2ETest/ServerExecutionTests/WebSocketCompressionTests.cs (2)

10-17: Namespace/using update looks good.

No issues with the namespace block change and added using.

Also applies to: 209-209

---

101-102: Quarantined test annotation is appropriate.

This cleanly marks the flaky test without changing test logic.

eng/PlatformManifest.txt (1)

1-143: Manifest addition looks fine.

Data-only platform manifest is consistent with the baseline update.

eng/common/SetupNugetSources.ps1 (1)

177-187: LGTM.

NuGet.config (1)

7-7: LGTM.

eng/common/SetupNugetSources.sh (1)

4-6: LGTM.

Also applies to: 177-187

eng/common/core-templates/steps/install-microbuild.yml (1)

20-29: LGTM.

Also applies to: 67-68, 87-88

eng/Version.Details.props (1)

9-100: LGTM.

eng/Version.Details.xml (1)

11-334: LGTM.

Also applies to: 361-454

global.json (1)

3-6: Ensure NuGet.config includes the internal dotnet-eng feed for MSBuild SDK packages.

The .NET SDK 10.0.100-rc.2.25502.107 is available from the official Microsoft .NET download page. However, the Arcade/Helix/SharedFramework SDK packages (version 10.0.0-beta.25555.106) are published only to the internal dotnet-eng Azure Artifacts feed, not public NuGet.org. Add or verify this feed in your repo's NuGet.config:

<add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />

Also applies to: 30-32

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# First, let's read the YAML file to see the context and all instances
cat -n .azure/pipelines/jobs/default-build.yml | sed -n '160,170p'

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 700

---

🏁 Script executed:

# Check the second instance mentioned at lines 391-393
cat -n .azure/pipelines/jobs/default-build.yml | sed -n '385,400p'

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 1065

---

🏁 Script executed:

# Let's also search for all Xcode references in the file
rg -n "Xcode" .azure/pipelines/jobs/default-build.yml

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 274

---

🏁 Script executed:

# Check if there's any documentation about macOS agent versions
find . -type f \( -name "*.md" -o -name "*.yml" -o -name "*.yaml" \) | xargs rg -l "macOS.*agent\|Xcode.*version" | head -20

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 71

---

🏁 Script executed:

# Check git history for this file to see recent changes
git log --oneline -20 .azure/pipelines/jobs/default-build.yml

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 107

---

🏁 Script executed:

# Look for any comments or documentation in the file itself
cat -n .azure/pipelines/jobs/default-build.yml | head -50

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 2786

---

🏁 Script executed:

# Search for any configuration or variable definitions related to Xcode
rg -i "xcode\|macos.*15\|xcode.*version" --type yaml -A 2 -B 2

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 71

---

🏁 Script executed:

# Search for agent pool specifications or macOS configuration
rg -i "agent.*pool\|macOS.*image\|image.*version" --type yaml -B 2 -A 2 | head -50

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 71

---

🏁 Script executed:

# Look for any comments in the pipeline about Xcode or agent versions
rg -i "xcode\|agent" .azure/pipelines/jobs/default-build.yml -B 2 -A 2

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 71

---

🏁 Script executed:

# Check if there's any PR or issue reference
git log -1 --format=%B b535239b

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 98

---

Fix Xcode version mismatch in macOS build steps (lines 166 and 392).

Both instances select Xcode_15.2.0.app but label says "Use XCode 16.4.0". Align the script path with the intended Xcode version or update the label if 15.2.0 is still required. This mismatch could cause failures on macOS agents where one version is unavailable.

🔧 Proposed fix (verify actual bundle name on the agent)

-        - script: sudo xcode-select -s /Applications/Xcode_15.2.0.app/Contents/Developer
+        - script: sudo xcode-select -s /Applications/Xcode_16.4.0.app/Contents/Developer
           displayName: Use XCode 16.4.0

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	- ${{ if eq(parameters.agentOs, 'macOS') }}:
	- script: sudo xcode-select -s /Applications/Xcode_15.2.0.app/Contents/Developer
	displayName: Use XCode 15.2.0
	displayName: Use XCode 16.4.0
	- ${{ if eq(parameters.agentOs, 'macOS') }}:
	- script: sudo xcode-select -s /Applications/Xcode_16.4.0.app/Contents/Developer
	displayName: Use XCode 16.4.0

🤖 Prompt for AI Agents

In @.azure/pipelines/jobs/default-build.yml around lines 165 - 167, Two macOS
build steps set xcode-select to /Applications/Xcode_15.2.0.app but use the label
"Use XCode 16.4.0", causing a version mismatch; locate the steps that contain
the lines "script: sudo xcode-select -s
/Applications/Xcode_15.2.0.app/Contents/Developer" and "displayName: Use XCode
16.4.0" and make them consistent by either changing the script path to the
correct bundle for Xcode 16.4 (e.g.,
/Applications/Xcode_16.4.0.app/Contents/Developer) or updating the displayName
to reflect Xcode 15.2.0, and verify the actual Xcode bundle name available on
the macOS agent before committing.

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# First, check if the files exist and examine their structure
echo "=== Checking file existence ==="
ls -lh eng/PackageOverrides.txt eng/Version.Details.props 2>&1 || echo "Files not found in expected locations"

echo ""
echo "=== First few lines of PackageOverrides.txt ==="
head -20 eng/PackageOverrides.txt 2>/dev/null || echo "File not found"

echo ""
echo "=== Checking Version.Details.props existence and size ==="
if [ -f eng/Version.Details.props ]; then
  wc -l eng/Version.Details.props
  echo "First 50 lines:"
  head -50 eng/Version.Details.props
else
  echo "Version.Details.props not found"
fi

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 6616

---

🏁 Script executed:

#!/bin/bash
# Run the provided verification script to compare overrides to Version.Details.props
python - <<'PY'
import xml.etree.ElementTree as ET
from pathlib import Path
import sys

# Check if PackageOverrides.txt exists
override_path = Path("eng/PackageOverrides.txt")
if not override_path.exists():
    print("ERROR: eng/PackageOverrides.txt not found")
    sys.exit(1)

overrides = {}
for line in override_path.read_text().splitlines():
    line = line.strip()
    if not line or line.startswith("#"):
        continue
    parts = line.split("|", 1)
    if len(parts) == 2:
        name, ver = parts
        overrides[name] = ver

print(f"Found {len(overrides)} packages in PackageOverrides.txt")
print("Sample overrides (first 10):")
for i, (k, v) in enumerate(list(overrides.items())[:10]):
    print(f"  {k}: {v}")

# Check if Version.Details.props exists
details_path = Path("eng/Version.Details.props")
if not details_path.exists():
    print(f"\nERROR: {details_path} not found")
    sys.exit(1)

try:
    root = ET.parse(str(details_path)).getroot()
    
    def iter_versions():
        for e in root.iter():
            inc = e.attrib.get("Include")
            ver = e.attrib.get("Version") or e.attrib.get("VersionOverride")
            if inc and ver:
                yield inc, ver
    
    details = dict(iter_versions())
    print(f"\nFound {len(details)} packages in Version.Details.props")
    print("Sample from Version.Details.props (first 10):")
    for i, (k, v) in enumerate(list(details.items())[:10]):
        print(f"  {k}: {v}")
    
    # Find mismatches
    mismatches = [(k, v, details[k]) for k, v in overrides.items() if k in details and details[k] != v]
    
    if mismatches:
        print(f"\n⚠️  Found {len(mismatches)} mismatches between PackageOverrides.txt and Version.Details.props:")
        for name, ov, ver in mismatches[:20]:  # Show first 20
            print(f"  {name}: override={ov} vs Version.Details={ver}")
        if len(mismatches) > 20:
            print(f"  ... and {len(mismatches) - 20} more")
    else:
        print("\n✓ No mismatches found. All overrides match Version.Details.props.")
    
    # Check how many packages are at 10.0.0
    count_10_0_0 = sum(1 for v in overrides.values() if v == "10.0.0")
    print(f"\nPackages pinned to 10.0.0: {count_10_0_0} out of {len(overrides)}")
    
except Exception as e:
    print(f"ERROR parsing XML: {e}")
    sys.exit(1)
PY

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 894

---

🏁 Script executed:

#!/bin/bash
# Parse Version.Details.props correctly using PropertyGroup format
python - <<'PY'
import xml.etree.ElementTree as ET
from pathlib import Path
from collections import Counter

# Read PackageOverrides
overrides = {}
for line in Path("eng/PackageOverrides.txt").read_text().splitlines():
    line = line.strip()
    if not line or line.startswith("#"):
        continue
    parts = line.split("|", 1)
    if len(parts) == 2:
        name, ver = parts
        overrides[name] = ver

# Parse Version.Details.props PropertyGroup format
root = ET.parse("eng/Version.Details.props").getroot()
details = {}

# Extract versions from PropertyGroup
for prop in root.findall(".//{http://schemas.microsoft.com/developer/msbuild/2003}PropertyGroup/*"):
    # Property name is the tag name
    prop_name = prop.tag.split('}')[-1]  # Remove namespace
    prop_value = prop.text
    if prop_value:
        details[prop_name] = prop_value

print(f"Found {len(details)} properties in Version.Details.props")
print(f"Found {len(overrides)} packages in PackageOverrides.txt")

# Convert property names back to package names and compare
# Property names follow pattern: Microsoft*PackageVersion -> Microsoft.*
package_version_mapping = {}
for prop_name, prop_value in list(details.items())[:50]:
    print(f"  {prop_name}: {prop_value}")

# Count versions
version_counter = Counter(details.values())
print(f"\nVersion distribution in Version.Details.props:")
for ver, count in version_counter.most_common(10):
    print(f"  {ver}: {count} packages")

# Check for 10.0.1 vs 10.0.0
count_10_0_1 = sum(1 for v in details.values() if v.startswith("10.0.1"))
count_10_0_0 = sum(1 for v in details.values() if v == "10.0.0")

print(f"\nVersion.Details.props:")
print(f"  10.0.1 packages: {count_10_0_1}")
print(f"  10.0.0 packages: {count_10_0_0}")

print(f"\nPackageOverrides.txt:")
print(f"  All {len(overrides)} packages at: 10.0.0")

if count_10_0_1 > 0:
    print(f"\n⚠️  CRITICAL: PackageOverrides.txt pins packages to 10.0.0, but Version.Details.props has {count_10_0_1} packages at 10.0.1")
    print("This would mask servicing updates!")
PY

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 342

---

🏁 Script executed:

#!/bin/bash
# Simple text-based parsing of Version.Details.props
echo "=== Examining Version.Details.props structure ==="
head -80 eng/Version.Details.props

echo ""
echo "=== Extracting package versions (sample) ==="
grep -o '<[A-Za-z]*PackageVersion>[^<]*</[A-Za-z]*PackageVersion>' eng/Version.Details.props | head -30

echo ""
echo "=== Version statistics ==="
grep -o '>10\.[0-9]\.[0-9]' eng/Version.Details.props | sort | uniq -c

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 12004

---

🏁 Script executed:

#!/bin/bash
# Map PackageOverrides to Version.Details properties to find mismatches
python - <<'PY'
import re
from pathlib import Path

# Read overrides
overrides = {}
for line in Path("eng/PackageOverrides.txt").read_text().splitlines():
    line = line.strip()
    if not line or line.startswith("#"):
        continue
    parts = line.split("|", 1)
    if len(parts) == 2:
        name, ver = parts
        overrides[name] = ver

# Extract versions from Version.Details.props
details = {}
for line in Path("eng/Version.Details.props").read_text().splitlines():
    match = re.search(r'<([A-Za-z0-9]+)PackageVersion>([^<]+)</\1PackageVersion>', line)
    if match:
        prop_name = match.group(1)
        version = match.group(2)
        details[prop_name] = version

# Convert property names to package names (remove "PackageVersion" suffix and convert camelCase to dots)
def prop_to_package(prop):
    # Examples: MicrosoftExtensionsCachingAbstractionsPackageVersion -> Microsoft.Extensions.Caching.Abstractions
    # Remove PackageVersion suffix
    name = prop.replace("PackageVersion", "")
    
    # Handle special cases and CamelCase conversion
    # This is complex, so just keep raw for now
    return name

# Count versions in details
count_10_0_1 = sum(1 for v in details.values() if v == "10.0.1")
count_10_0_0 = sum(1 for v in details.values() if v == "10.0.0")
count_other = len(details) - count_10_0_1 - count_10_0_0

print(f"PackageOverrides.txt:")
print(f"  {len(overrides)} packages, all pinned to 10.0.0")

print(f"\nVersion.Details.props:")
print(f"  10.0.1: {count_10_0_1} packages")
print(f"  10.0.0: {count_10_0_0} packages")
print(f"  Other: {count_other} packages")

# Show some 10.0.1 packages that will be masked
print(f"\nSample packages at 10.0.1 in Version.Details.props that are overridden to 10.0.0:")
for prop, ver in list(details.items())[:10]:
    if ver == "10.0.1":
        print(f"  {prop}: {ver}")

print(f"\n✗ CRITICAL ISSUE: PackageOverrides.txt will mask {count_10_0_1} servicing updates from 10.0.1 to 10.0.0")
PY

Repository: qodo-benchmark/aspnetcore-combined-coderabbit

Length of output: 503

---

PackageOverrides.txt pins all 140 packages to 10.0.0, masking 77 servicing updates to 10.0.1 specified in eng/Version.Details.props.

These overrides will prevent critical Microsoft.Extensions.* and Microsoft.AspNetCore.* servicing updates (10.0.1) from being applied. Verify this downgrade is intentional; otherwise, remove or update the overrides to match Version.Details.props.

🤖 Prompt for AI Agents

In `@eng/PackageOverrides.txt` around lines 1 - 140, The overrides file pins ~140
Microsoft.* and Microsoft.AspNetCore.* packages to 10.0.0 which masks the
intended 10.0.1 servicing updates; remove or update those entries so they no
longer force 10.0.0. Edit the overrides list lines that set
Microsoft.Extensions.* and Microsoft.AspNetCore.* (the entries currently equal
to "10.0.0") and either delete those entries entirely or change their versions
to "10.0.1" to match eng/Version.Details.props, then run a restore/build to
verify the servicing updates are applied.