fix(companion): event type links for org user #26
Conversation
Addresses Cubic AI review feedback (confidence 9/10): The username was hardcoded to 'username' but still used by BasicsTab as a fallback for URL display when bookingUrl is unavailable. This restores the useEffect that fetches the actual username from CalComAPIService.getUsername(). Co-Authored-By: unknown <>
🤖 Augment PR SummarySummary: Updates the Companion app and browser extension to use an API-provided Changes:
Technical Notes: This relies on API V2 returning a full booking URL per event type; UI/extension behavior now depends on that field being present. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| const [conferencingOptions, setConferencingOptions] = useState<ConferencingOption[]>([]); | ||
| const [conferencingLoading, setConferencingLoading] = useState(false); | ||
| const [eventTypeData, setEventTypeData] = useState<EventType | null>(null); | ||
| const [bookingUrl, setBookingUrl] = useState<string>(""); |
There was a problem hiding this comment.
bookingUrl is introduced as state here but never set anywhere (no setBookingUrl(...) usage), so handlePreview/handleCopyLink will always hit the "Booking URL not available" error path and BasicsTab will never receive the real URL.
Other Locations
companion/app/(tabs)/(event-types)/event-type-detail.tsx:949companion/app/(tabs)/(event-types)/event-type-detail.tsx:957companion/app/(tabs)/(event-types)/event-type-detail.tsx:1430
🤖 Was this useful? React with 👍 or 👎
| const bookingUrl = `https://cal.com/${ | ||
| eventType.users?.[0]?.username || "user" | ||
| }/${eventType.slug}`; | ||
| const bookingUrl = |
There was a problem hiding this comment.
This copy-to-clipboard handler still hardcodes https://cal.com/{username}/{slug} and ignores eventType.bookingUrl, so org/team event type links can still be copied incorrectly even though other handlers in this file now prefer bookingUrl.
🤖 Was this useful? React with 👍 or 👎
Benchmark PR from qodo-benchmark#706