-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: Remove trpc/server dependency from @calcom/atoms #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: augment_combined_20260121_augment_sentry_coderabbit_1_base_refactor_remove_trpc_server_dependency_from_calcom_atoms_pr716
Are you sure you want to change the base?
Conversation
🤖 Augment PR SummarySummary: Refactors the platform Changes:
Technical Note: This keeps atoms decoupled from server-only tRPC modules while preserving type coverage for the REST endpoints it calls. 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| export type Slot = { | ||
| time: string; | ||
| userIds?: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| bookingUid?: string; | ||
| away?: boolean; | ||
| fromUser?: { | ||
| id: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| id: number; | ||
| userId: number | null; | ||
| eventTypeId: number | null; | ||
| days: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
availability.days is typed as string[], but the atoms /schedules/all endpoint delegates to the tRPC availability list handler which returns numeric weekday indices (number[]) from Prisma. This mismatch can break consumers like getScheduleListItemData/ScheduleListItem that expect number[].
🤖 Was this useful? React with 👍 or 👎
| throw new Error('Invalid input: name must be a non-empty string'); | ||
| } | ||
|
|
||
| return data as CreateScheduleInput; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark PR from qodo-benchmark#716