refactor: Remove trpc/server dependency from @calcom/atoms #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
|
||
| export type Slot = { | ||
| time: string; | ||
| userIds?: string[]; |
There was a problem hiding this comment.
🔴 Type mismatch: Slot.userIds changed from number[] to string[]
The new Slot type in packages/platform/atoms/booker/types.ts has userIds?: string[] but the original type that was removed from packages/trpc/server/routers/viewer/slots/types.ts had userIds?: number[].
Click to expand
Original type (removed from trpc):
export type Slot = {
time: string;
userIds?: number[]; // numbers
...
};New type (in atoms):
export type Slot = {
time: string;
userIds?: string[]; // strings - INCORRECT
...
};The internal implementation in packages/trpc/server/routers/viewer/slots/util.ts:1362-1367 still uses userIds?: number[], confirming the actual data uses numbers. This type mismatch could cause:
- Runtime errors when code expects numbers but receives strings
- Incorrect comparisons (e.g.,
1 === "1"is false) - Breaking consumers that rely on numeric userIds
Recommendation: Change userIds?: string[] to userIds?: number[] to match the original type definition and the actual data types used in the codebase.
Was this helpful? React with 👍 or 👎 to provide feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#716