Skip to content

Conversation

@tomerqodo
Copy link

Benchmark PR calcom#26600

Type: Clean (correct implementation)

Original PR Title: refactor: Extract schedule determination to seperate fn
Original PR Description:

Summary by cubic

Extracted schedule selection into a dedicated function to simplify getUserAvailability and make timezone fallback logic clearer. No functional changes expected.

  • Refactors
    • Added detectEventTypeScheduleForUser to choose schedule and report isDefaultSchedule/isTimezoneSet.
    • Introduced ScheduleWithoutTimeZone and DEFAULT_SCHEDULE_DATA.
    • Simplified timezone resolution, using delegated calendar TZ only when needed.
    • Made GetUserAvailabilityResult explicit and typed _getUserAvailability accordingly.
    • Imported WorkingHoursWithUserId and removed inline schedule logic and redundant debug logging.

Written for commit 6bf6b44. Summary will update on new commits.

Original PR URL: calcom#26600

@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CLEAN] Synthetic Benchmark PR #26600 - refactor: Extract schedule determination to seperate fn". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions
Copy link

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@github-actions github-actions bot added the Stale label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants