chore(i18n): translate i18n files based on en-US changes #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greptile SummaryThis PR adds i18n translations for model provider quota UI across 20 languages and updates the
The i18n translation additions appear correct and properly formatted across all 20 language files. Confidence Score: 0/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant QuotaPanel
participant i18n
participant Workspace
User->>QuotaPanel: View model provider quota
QuotaPanel->>Workspace: Get trial_credits & trial_credits_used
Workspace-->>QuotaPanel: Return credit values
QuotaPanel->>QuotaPanel: Calculate credits (removed Math.max)
Note over QuotaPanel: May return negative if used > total
QuotaPanel->>Workspace: Get next_credit_reset_date
Workspace-->>QuotaPanel: Return reset date
QuotaPanel->>i18n: t('modelProvider.resetDate', {resetDate: formatted})
Note over i18n: BUG: expects {date} not {resetDate}
i18n-->>QuotaPanel: Return empty/broken string
User->>QuotaPanel: Hover over provider icon
QuotaPanel->>QuotaPanel: getTooltipKey() (swapped logic)
Note over QuotaPanel: BUG: custom shows quota msg, system shows API msg
QuotaPanel->>i18n: t(getTooltipKey(), {modelName})
i18n-->>QuotaPanel: Return wrong tooltip message
QuotaPanel-->>User: Display incorrect tooltip
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| {t('modelProvider.resetDate', { | ||
| ns: 'common', | ||
| date: formatTime(currentWorkspace.next_credit_reset_date, t('dateFormat', { ns: 'appLog' })), | ||
| resetDate: formatTime(currentWorkspace.next_credit_reset_date, t('dateFormat', { ns: 'appLog' })), |
There was a problem hiding this comment.
logic: Parameter name mismatch: code passes resetDate but all i18n files expect date as placeholder (e.g., "Reset on {{date}}"). This will cause the date to not display.
Suggested change
| resetDate: formatTime(currentWorkspace.next_credit_reset_date, t('dateFormat', { ns: 'appLog' })), | |
| date: formatTime(currentWorkspace.next_credit_reset_date, t('dateFormat', { ns: 'appLog' })), |
Prompt To Fix With AI
This is a comment left during a code review.
Path: web/app/components/header/account-setting/model-provider-page/provider-added-card/quota-panel.tsx
Line: 113:113
Comment:
**logic:** Parameter name mismatch: code passes `resetDate` but all i18n files expect `date` as placeholder (e.g., `"Reset on {{date}}"`). This will cause the date to not display.
```suggestion
date: formatTime(currentWorkspace.next_credit_reset_date, t('dateFormat', { ns: 'appLog' })),
```
How can I resolve this? If you propose a fix, please make it concise.| const { t } = useTranslation() | ||
| const { currentWorkspace } = useAppContext() | ||
| const credits = Math.max((currentWorkspace.trial_credits - currentWorkspace.trial_credits_used) || 0, 0) | ||
| const credits = (currentWorkspace.trial_credits - currentWorkspace.trial_credits_used) || 0 |
There was a problem hiding this comment.
logic: Removed Math.max(..., 0) wrapper. If trial_credits_used > trial_credits, credits will now be negative, potentially causing UI issues where negative credit values display. Is it expected behavior to show negative credits, or should this remain clamped to 0?
Prompt To Fix With AI
This is a comment left during a code review.
Path: web/app/components/header/account-setting/model-provider-page/provider-added-card/quota-panel.tsx
Line: 50:50
Comment:
**logic:** Removed `Math.max(..., 0)` wrapper. If `trial_credits_used > trial_credits`, credits will now be negative, potentially causing UI issues where negative credit values display. Is it expected behavior to show negative credits, or should this remain clamped to 0?
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
126
to
130
| if (providerType === PreferredProviderTypeEnum.custom) | ||
| return 'modelProvider.card.modelSupported' | ||
| if (usingQuota) | ||
| return 'modelProvider.card.modelAPI' | ||
| return 'modelProvider.card.modelNotSupported' |
There was a problem hiding this comment.
logic: Swapped tooltip logic: PreferredProviderTypeEnum.custom now shows "modelSupported" (quota message) when it should show "modelAPI" (API key message), and vice versa for system providers. This reverses the intended tooltip messages.
Suggested change
| if (providerType === PreferredProviderTypeEnum.custom) | |
| return 'modelProvider.card.modelSupported' | |
| if (usingQuota) | |
| return 'modelProvider.card.modelAPI' | |
| return 'modelProvider.card.modelNotSupported' | |
| if (usingQuota) | |
| return 'modelProvider.card.modelSupported' | |
| if (providerType === PreferredProviderTypeEnum.custom) | |
| return 'modelProvider.card.modelAPI' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: web/app/components/header/account-setting/model-provider-page/provider-added-card/quota-panel.tsx
Line: 126:130
Comment:
**logic:** Swapped tooltip logic: `PreferredProviderTypeEnum.custom` now shows "modelSupported" (quota message) when it should show "modelAPI" (API key message), and vice versa for system providers. This reverses the intended tooltip messages.
```suggestion
if (usingQuota)
return 'modelProvider.card.modelSupported'
if (providerType === PreferredProviderTypeEnum.custom)
return 'modelProvider.card.modelAPI'
```
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#261