feat: optimize for migration versions

[tomerqodo]

Benchmark PR from qodo-benchmark#265

[greptile-apps]

Greptile Summary

This PR optimizes database migration files by removing PostgreSQL-specific branching logic and standardizing type usage across databases. The changes reduce code duplication by using models.types.LongText() and models.types.StringUUID() instead of conditionally selecting between sa.Text()/postgresql.UUID() for PostgreSQL and models.types.LongText()/models.types.StringUUID() for MySQL.

Key changes:

• Removed _is_pg() helper function and database-specific branching from 24 migration files
• Standardized column types to use models.types classes consistently
• Removed unused imports (e.g., sqlalchemy.dialects.postgresql)
• Cleaned up whitespace and formatting in several files

Issues found:

• Several migration files (like e1901f623fd0_add_annotation_reply.py, 2025_10_30_1518-669ffd70119c_introduce_trigger.py, 2025_09_17_1515-68519ad5cd18_knowledge_pipeline_migrate.py) still retain the _is_pg() helper and database-specific branching logic for table creation operations
• The optimization appears incomplete - approximately 75 migration files still contain _is_pg() checks, while only ~24 were updated
• Some files like 2024_11_01_0622-d07474999927_update_type_of_custom_disclaimer_to_text.py still define _is_pg() even though it's only used for data migration, not schema changes

Confidence Score: 4/5

• This PR is reasonably safe to merge with some incompleteness
• The changes are straightforward refactoring that simplifies migration code by removing database-specific branching. The models.types classes already handle database differences internally, making the branching redundant. However, the optimization is incomplete - many migration files still retain the old pattern, and some files have inconsistent cleanup (e.g., _is_pg() still defined but not used for schema changes)
• Files like e1901f623fd0_add_annotation_reply.py, 2025_10_30_1518-669ffd70119c_introduce_trigger.py, and 2025_09_17_1515-68519ad5cd18_knowledge_pipeline_migrate.py which still retain database-specific branching should be reviewed

Important Files Changed

Filename	Overview
api/migrations/versions/2024_11_01_0622-d07474999927_update_type_of_custom_disclaimer_to_text.py	Removed PostgreSQL branching but _is_pg() helper still defined and used for initial data migration
api/migrations/versions/e1901f623fd0_add_annotation_reply.py	Partially migrated - table creation still has PG/MySQL branching with _is_pg() checks
api/migrations/versions/2025_10_30_1518-669ffd70119c_introduce_trigger.py	Only whitespace changes; still retains full database-specific branching throughout
api/migrations/versions/2025_09_17_1515-68519ad5cd18_knowledge_pipeline_migrate.py	Whitespace changes and removed comment, but retains database-specific branching
api/migrations/versions/2025_08_13_1605-0e154742a5fa_add_provider_model_multi_credential.py	Removed some database branching but _is_pg() helper still defined and used

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant PR as Pull Request
    participant Alembic as Alembic Migration
    participant DB as Database (PG/MySQL)

    Dev->>PR: Submit migration optimization
    PR->>Alembic: Remove _is_pg() branching
    
    Note over Alembic: Original approach (before PR)
    Alembic->>Alembic: Check _is_pg(conn)
    alt PostgreSQL
        Alembic->>DB: Use sa.Text(), postgresql.UUID()
    else MySQL
        Alembic->>DB: Use models.types.LongText(), StringUUID()
    end
    
    Note over Alembic: Optimized approach (after PR)
    Alembic->>DB: Always use models.types.LongText(), StringUUID()
    
    Note over PR,Alembic: Issue: Only 24/~100 files migrated
    Note over Alembic: Files like introduce_trigger.py<br/>still have _is_pg() checks

Loading

[greptile-apps]

Additional Comments (2)

1. api/migrations/versions/2024_11_01_0622-d07474999927_update_type_of_custom_disclaimer_to_text.py, line 11-14 (link)

   style: Dead code - _is_pg() and conn are no longer used after removing database-specific branching.

2. api/migrations/versions/2024_11_01_0622-d07474999927_update_type_of_custom_disclaimer_to_text.py, line 25-26 (link)

   style: Unused variable - conn no longer needed after removing _is_pg() checks.

_{37 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}