chore: remove icon_large of models

[tomerqodo]

Benchmark PR from qodo-benchmark#267

[greptile-apps]

Greptile Summary

This PR removes the icon_large field from model provider entities across backend and frontend code. However, the refactoring introduces 4 critical bugs that will cause runtime failures when handling provider icons.

Critical Issues Found:

• SimpleModelProviderEntity.__init__() still passes removed icon_large parameter to parent class, causing TypeError
• ProviderEntity.to_simple_provider_entity() incorrectly assigns icon_small to icon_small_dark field, losing dark theme icon data
• ModelProviderFactory.get_provider_icon() retrieves from wrong field when icon_type is icon_small_dark
• ProviderResponse validator has duplicate condition check preventing icon_small_dark from being properly set when it exists independently

Changes Summary:

• Removed icon_large field from all entity classes (backend and frontend types)
• Removed icon_large from service layer response mapping
• Cleaned up test fixtures and mock data
• Updated docstrings to reflect supported icon types

Confidence Score: 0/5

• This PR is NOT safe to merge - contains 4 critical bugs that will cause runtime failures in production
• The PR introduces critical runtime errors: (1) TypeError in SimpleModelProviderEntity initialization due to removed parameter still being passed, (2) logic error losing dark icon data by assigning icon_small to icon_small_dark field, (3) wrong field access when retrieving dark icons, (4) broken validator condition preventing dark icon URL generation. These bugs will cause immediate failures when accessing provider icons or initializing provider entities.
• api/core/entities/model_entities.py, api/core/model_runtime/entities/provider_entities.py, api/core/model_runtime/model_providers/model_provider_factory.py, api/services/entities/model_provider_entities.py

Important Files Changed

Filename	Overview
api/core/entities/model_entities.py	Removed icon_large field from SimpleModelProviderEntity but code still passes it to super().init(), causing runtime TypeError
api/core/model_runtime/entities/provider_entities.py	Assigns icon_small to icon_small_dark field in to_simple_provider_entity() method, losing dark icon data
api/core/model_runtime/model_providers/model_provider_factory.py	When icon_type is icon_small_dark, retrieves from icon_small field instead of icon_small_dark, returning wrong icon
api/services/entities/model_provider_entities.py	Duplicate condition check on icon_small prevents icon_small_dark from being set with proper URL when it exists independently

Sequence Diagram

sequenceDiagram
    participant Client
    participant ModelProviderService
    participant ProviderEntity
    participant SimpleProviderEntity
    participant ModelProviderFactory

    Client->>ModelProviderService: get_provider_icon(provider, icon_type)
    ModelProviderService->>ModelProviderFactory: get_provider_icon(provider, icon_type, lang)
    ModelProviderFactory->>ProviderEntity: get_provider_schema(provider)
    
    alt icon_type == "icon_small"
        ModelProviderFactory->>ProviderEntity: access icon_small field
    else icon_type == "icon_small_dark"
        ModelProviderFactory->>ProviderEntity: access icon_small field (BUG: should be icon_small_dark)
    else other
        ModelProviderFactory-->>ModelProviderService: raise ValueError
    end
    
    ModelProviderFactory-->>Client: return icon bytes and mime type

Loading

[greptile-apps]

Additional Comments (4)

1. api/core/entities/model_entities.py, line 41-48 (link)

   syntax: icon_large parameter is passed to super().__init__() on line 46, but the field was removed from the class definition (line 32). This will cause a TypeError at runtime.

2. api/core/model_runtime/entities/provider_entities.py, line 154-161 (link)

   logic: icon_small_dark is being set to self.icon_small instead of self.icon_small_dark. This loses the dark icon information and assigns the small icon to both fields.

3. api/core/model_runtime/model_providers/model_provider_factory.py, line 303-310 (link)

   logic: When retrieving the icon_small_dark icon, the code reads from provider_schema.icon_small instead of provider_schema.icon_small_dark, causing the wrong icon to be returned.

4. api/services/entities/model_provider_entities.py, line 91-100 (link)

   logic: Line 95 checks if self.icon_small is not None instead of if self.icon_small_dark is not None, causing icon_small_dark to only be set when icon_small exists. This breaks the logic for setting dark icon URLs.

_{13 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}