chore: Standardized the OpenAI icon

[tomerqodo]

Benchmark PR from qodo-benchmark#269

[greptile-apps]

Greptile Summary

Standardized OpenAI icon usage by removing color-specific variants (Blue, Teal, Violet) and using only the Yellow icon for all OpenAI models starting with 'o'. Made the model name check case-insensitive and added error handling for invalid icon sources.

Key changes:

• Removed 3 color-specific OpenAI icon variants (Blue, Teal, Violet) and their JSON definitions
• Simplified model icon logic to use single OpenaiYellow icon for all OpenAI models starting with 'o'
• Changed modelName?.startsWith('o') to modelName?.toLowerCase().startsWith('o') for case-insensitive matching
• Added try-catch block with validation for icon source rendering
• Critical bug introduced: Line 45 has logical error where isDeprecated || should be isDeprecated &&, causing all non-deprecated icons to display with reduced opacity

Confidence Score: 1/5

• This PR contains a critical logical error that will cause visual bugs in production
• The PR introduces a critical bug on line 45 where isDeprecated || should be isDeprecated &&. This inverts the opacity logic, causing all non-deprecated icons to display with reduced opacity (50%) instead of deprecated ones. This will immediately affect the visual presentation of model icons across the application.
• web/app/components/header/account-setting/model-provider-page/model-icon/index.tsx requires immediate attention due to the logical operator error on line 45

Important Files Changed

Filename	Overview
web/app/components/base/icons/src/public/llm/index.ts	Removed exports for deleted OpenAI color variant icons
web/app/components/header/account-setting/model-provider-page/model-icon/index.tsx	Replaced specific OpenAI model icon logic with single yellow icon; introduced critical logical error in isDeprecated check

Sequence Diagram

sequenceDiagram
    participant User
    participant ModelIcon
    participant OpenaiYellow
    participant IconBase
    participant ThemeHook
    participant i18n

    User->>ModelIcon: Render icon for model
    ModelIcon->>ThemeHook: useTheme()
    ThemeHook-->>ModelIcon: theme
    ModelIcon->>i18n: useLanguage()
    i18n-->>ModelIcon: language
    
    alt OpenAI provider && model starts with 'o'
        ModelIcon->>OpenaiYellow: Render OpenaiYellow icon
        OpenaiYellow->>IconBase: Pass icon data
        IconBase-->>ModelIcon: Rendered icon
    else Provider has icon_small
        ModelIcon->>ModelIcon: try-catch block
        ModelIcon->>i18n: renderI18nObject(icon_small, language)
        i18n-->>ModelIcon: iconSrc
        alt iconSrc is valid
            ModelIcon->>ModelIcon: Render img with iconSrc
        else iconSrc is invalid
            ModelIcon->>ModelIcon: throw Error
        end
    else No icon available
        ModelIcon->>ModelIcon: Render default Group icon
    end
    
    ModelIcon-->>User: Return icon component

Loading

[greptile-apps]

_{8 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

logic: Logical error: isDeprecated || should be isDeprecated &&. Currently, non-deprecated icons have opacity-50 applied (when isDeprecated is false, the expression evaluates to 'opacity-50'). The original code was isDeprecated && 'opacity-50'.

Suggested change

	<div className={cn('flex h-5 w-5 items-center justify-center', isDeprecated || 'opacity-50', className)}>
	<div className={cn('flex h-5 w-5 items-center justify-center', isDeprecated && 'opacity-50', className)}>

Prompt To Fix With AI

This is a comment left during a code review.
Path: web/app/components/header/account-setting/model-provider-page/model-icon/index.tsx
Line: 45:45

Comment:
**logic:** Logical error: `isDeprecated ||` should be `isDeprecated &&`. Currently, non-deprecated icons have opacity-50 applied (when `isDeprecated` is false, the expression evaluates to `'opacity-50'`). The original code was `isDeprecated && 'opacity-50'`.

```suggestion
        <div className={cn('flex h-5 w-5 items-center justify-center', isDeprecated && 'opacity-50', className)}>
```

How can I resolve this? If you propose a fix, please make it concise.