chore: remove useless __esModule#82
Conversation
Greptile SummaryThis PR removes the The changes are purely cleanup, removing redundant boilerplate that serves no functional purpose in Vitest. All mocks continue to work identically after the removal since Vitest's module mocking system treats Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Test as Test Files (79 files)
participant Vitest as Vitest Mock System
participant Module as Module Loader
Note over Dev,Module: Before: With __esModule flag
Dev->>Test: vi.mock('module', { __esModule: true, default: ... })
Test->>Vitest: Register mock with __esModule flag
Vitest->>Module: Load mock (flag ignored, not needed)
Module-->>Vitest: Return mocked module
Note over Dev,Module: After: Without __esModule flag
Dev->>Test: vi.mock('module', { default: ... })
Test->>Vitest: Register mock without flag
Vitest->>Module: Load mock (auto-detects ES module)
Module-->>Vitest: Return mocked module (identical behavior)
Note over Dev,Test: Result: 161 __esModule properties removed<br/>No functional change in test execution
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#277