refactor: always preserve marketplace search state in URL#147
Conversation
Code Review by Qodo
1. usePluginPageContext uses any
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| } | ||
|
|
||
| export function usePluginPageContext(selector: (value: PluginPageContextValue) => any) { | ||
| export function usePluginPageContext(selector: any) { |
There was a problem hiding this comment.
1. usepluginpagecontext uses any 📘 Rule violation ✓ Correctness
• The selector parameter was changed to an explicit any, which disables TypeScript’s type checking for this API surface and can hide real type errors. • This violates the requirement to avoid explicit any types and can lead to unsafe usage across all call sites of usePluginPageContext.
Agent prompt
## Issue description
`usePluginPageContext` currently accepts `selector: any`, which disables type safety and violates the no-explicit-any requirement.
## Issue Context
This hook is part of a shared context API; leaving `any` here propagates unsafe typing to all consumers.
## Fix Focus Areas
- web/app/components/plugins/plugin-page/context.tsx[51-52]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| const isSearchMode = !!searchPluginText | ||
| || filterPluginTags.length > 0 | ||
| || (searchMode ?? (!PLUGIN_CATEGORY_WITH_COLLECTIONS.has(activePluginType))) | ||
| || (searchMode ?? (PLUGIN_CATEGORY_WITH_COLLECTIONS.has(activePluginType))) |
There was a problem hiding this comment.
2. Collections view never shows 🐞 Bug ✓ Correctness
• useMarketplaceSearchMode now defaults to search mode when the active category is in PLUGIN_CATEGORY_WITH_COLLECTIONS (including the default all). • This makes useMarketplaceData always build queryParams and run the plugins search query on initial load, so the collections UI path is skipped. • Users can see an empty state or unintended search results instead of curated collections, and the page does extra network work.
Agent prompt
## Issue description
Marketplace defaults into search mode for categories that have collections (including `all`), preventing the collections view from rendering and triggering search queries with empty criteria.
## Issue Context
`PLUGIN_CATEGORY_WITH_COLLECTIONS` includes `all` and `tool`. The List UI renders collections only when `plugins` is `undefined`, but `useMarketplaceData` will always produce `queryParams` (and thus `plugins`) when search mode is true.
## Fix Focus Areas
- web/app/components/plugins/marketplace/atoms.ts[35-45]
- web/app/components/plugins/marketplace/constants.ts[25-30]
- web/app/components/plugins/marketplace/state.ts[20-36]
- web/app/components/plugins/marketplace/list/index.tsx[29-38]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
22
to
24
| export function useActivePluginType() { | ||
| const preserveSearchStateInQuery = useAtomValue(preserveSearchStateInQueryAtom) | ||
| const queryState = useQueryState('category', marketplaceSearchParamsParsers.category) | ||
| const atomState = useAtom(activePluginTypeAtom) | ||
| return preserveSearchStateInQuery ? queryState : atomState | ||
| return useQueryState('tab', marketplaceSearchParamsParsers.category) | ||
| } |
There was a problem hiding this comment.
3. Ssr/tab param mismatch 🐞 Bug ⛯ Reliability
• useActivePluginType now reads/writes query param tab, but the shared parsers and server hydration still parse category. • SSR prefetch (HydrateQueryClient) will ignore tab and default to category=all, causing wrong prefetched data and client/server mismatch (layout shift + wasted requests) on direct links like ?tab=tool. • Existing deep links or surrounding code that sets category (e.g., PluginPageContext) no longer drive the marketplace category selection.
Agent prompt
## Issue description
Marketplace category is stored in URL param `tab` on the client, but server-side parsing/hydration still reads `category`. This breaks SSR prefetch and any deep links using the old param.
## Issue Context
`createLoader(marketplaceSearchParamsParsers)` only loads keys present on the parser object (`category`, `q`, `tags`). `useActivePluginType` now writes `tab`, so SSR cannot see it.
## Fix Focus Areas
- web/app/components/plugins/marketplace/atoms.ts[19-27]
- web/app/components/plugins/marketplace/search-params.ts[5-9]
- web/app/components/plugins/marketplace/hydration-server.tsx[16-28]
- web/app/components/plugins/plugin-page/context.tsx[66-73]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#9