Skip to content

Conversation

@tomerqodo
Copy link

Benchmark PR electron#48973

Type: Clean (correct implementation)

Original PR Title: fix: revert enabling WASM trap handlers in all Node.js processes
Original PR Description: #### Description of Change

Addresses electron#48956

Looking into the dmp file stacktrace attached to the above issue, the wasm trap handlers appear to be crashing shortly after app launch. This PR reverts the change while we investigate and find a forward fix.

This reverts commit ca0b46b and PR electron#48788

Checklist

Release Notes

Notes: Fixed an issue where some apps would throw an exception on launch.

Original PR URL: electron#48973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants