Remove FXIOS-14327 [Clean up] Inactive tabs removal part 2 (final) #15
Conversation
🤖 Augment PR SummarySummary: Removes the remaining “Inactive Tabs” (FXIOS-14327) implementation from the iOS tab tray. Changes:
Technical Notes: Tab tray scrolling and snapshot/index assumptions now rely on a single 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| // not contain a selected tab. In that case, we should scroll to the bottom of the panel. | ||
| // Note: Could optimize further by scrolling to the most recent tab if we had `lastExecutedTime` in our model | ||
| return ScrollState(toIndex: state.tabs.count - 1, isInactiveTabSection: false, withAnimation: shouldAnimate) | ||
| return ScrollState(toIndex: state.tabs.count, withAnimation: shouldAnimate) |
There was a problem hiding this comment.
ScrollState(toIndex: state.tabs.count, ...) looks off-by-one (last valid row is count - 1) and can produce an invalid index path / failing tests when scrolling to the “bottom” without a selected tab.
🤖 Was this useful? React with 👍 or 👎
| private func scrollToTab(_ scrollState: TabsPanelState.ScrollState) { | ||
| let section: Int = scrollState.isInactiveTabSection ? 0 : 1 | ||
| let indexPath = IndexPath(row: scrollState.toIndex, section: section) | ||
| let indexPath = IndexPath(row: scrollState.toIndex, section: 1) |
There was a problem hiding this comment.
scrollToTab now hard-codes section: 1, but the data source snapshot only appends the .tabs section (index 0); this likely prevents scrolling (or can hit invalid index paths) after removing the inactive tabs section.
🤖 Was this useful? React with 👍 or 👎
| // License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| // file, You can obtain one at http://mozilla.org/MPL/2.0/ | ||
|
|
||
| import Redux |
There was a problem hiding this comment.
This file no longer includes the MPL 2.0 header comment that exists in many other source files; worth confirming this removal is intentional and still meets the repo’s licensing/header requirements.
🤖 Was this useful? React with 👍 or 👎
Benchmark PR from qodo-benchmark#230