Skip to content

EXP-5874 Add strings for Rollouts toggle and update Studies strings #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomerqodo wants to merge 2 commits into
base: coderabbit_full_base_exp-5874_add_strings_for_rollouts_toggle_and_update_studies_strings_pr1
Choose a base branch
from
Open

EXP-5874 Add strings for Rollouts toggle and update Studies strings #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06d0e3a
EXP-5874 Add strings for Rollouts toggle and update Studies strings (…
gruberb Dec 10, 2025
a606e5b
update pr
tomerqodo Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/l10n/linter_config_ios.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
},
"quotes": {
"enabled": true,
"exclusions": []
"exclusions": [
"firefox-ios.xliff:Settings.Studies.Message.v148"
]
},
"placeables": {
"enabled": true,
Expand Down
30 changes: 30 additions & 0 deletions firefox-ios/Shared/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6229,6 +6229,36 @@ extension String {
tableName: "Settings",
value: "Try out features and ideas before they’re released to everyone.",
comment: "A short description that explains that Mozilla is running studies")
public static let StudiesSettingTitleV3 = MZLocalizedString(
key: "Settings.Studies.Title.v148",
tableName: "Settings",
value: "Allow Feature Studies",
comment: "Label used as a toggle item in Settings. When this is off, the user is opting out of all studies.")
public static let StudiesSettingLinkV3 = MZLocalizedString(
key: "Settings.Studies.Link.v148",
tableName: "Settings",
value: "Learn More",
comment: "Title for a link that explains what Mozilla means by Studies")
public static let StudiesSettingMessageV3 = MZLocalizedString(
key: "Settings.Studies.Message.v148",
tableName: "Settings",
value: "%@ randomly selects users to test features, which improves quality for everyone.",
comment: "A short description that explains that Mozilla is running studies. %@ is the app name (e.g. Firefox).")
public static let RolloutsSettingTitle = MZLocalizedString(
key: "Settings.Rollouts.Title.v148",
tableName: "Settings",
value: "Allow Remote Improvements",
comment: "Label used as a toggle item in Settings. When this is off, the user is opting out of all rollouts.")
public static let RolloutsSettingLink = MZLocalizedString(
key: "Settings.Rollouts.Link.v148",
tableName: "Settings",
value: "Learn More",
comment: "Title for a link that explains what Mozilla means by Rollouts")
public static let RolloutsSettingMessage = MZLocalizedString(
key: "Settings.Rollouts.Message.v148",
tableName: "Settings",
value: "%@ will improve features, performance, and stability between updates. Changes applied remotely.",
comment: "A short description that explains that Mozilla may change features remotely. %1$@ is the app name (e.g. Firefox).")
Comment on lines +6258 to +6261
Copy link

@coderabbitai coderabbitai bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Align placeholder spec with the comment (positional).

The comment documents %1$@, but the value uses %@. Use a positional specifier (or update the comment) to avoid confusion and allow reordering in localized strings.

🛠️ Proposed fix 
-        value: "%@ will improve features, performance, and stability between updates. Changes applied remotely.",
+        value: "%1$@ will improve features, performance, and stability between updates. Changes applied remotely.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
key: "Settings.Rollouts.Message.v148",
tableName: "Settings",
value: "%@ will improve features, performance, and stability between updates. Changes applied remotely.",
comment: "A short description that explains that Mozilla may change features remotely. %1$@ is the app name (e.g. Firefox).")
key: "Settings.Rollouts.Message.v148",
tableName: "Settings",
value: "%1$@ will improve features, performance, and stability between updates. Changes applied remotely.",
comment: "A short description that explains that Mozilla may change features remotely. %1$@ is the app name (e.g. Firefox).")
🤖 Prompt for AI Agents 
In `@firefox-ios/Shared/Strings.swift` around lines 6258 - 6261, The localized
string for key "Settings.Rollouts.Message.v148" uses a non-positional specifier
("%@") but the comment documents a positional placeholder ("%1$@"); update the
value to use a positional specifier (replace "%@" with "%1$@") so it matches the
comment and supports reordering in translations; ensure you only change the
value string for that key in Strings.swift (or alternatively update the comment
if you intentionally want a non-positional specifier).

public static let SettingsSiriSectionName = MZLocalizedString(
key: "Settings.Siri.SectionName",
tableName: nil,
Expand Down
18 changes: 18 additions & 0 deletions firefox-ios/Shared/Supporting Files/en-CA.lproj/Settings.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,12 +235,30 @@
/* Title for a link that explains what Mozilla means by Studies */
"Settings.Studies.Link.v136" = "Learn More";

/* Title for a link that explains what Mozilla means by Studies */
"Settings.Studies.Link.v148" = "Learn More";

/* A short description that explains that Mozilla is running studies */
"Settings.Studies.Message.v136" = "Try out features and ideas before they’re released to everyone.";

/* A short description that explains that Mozilla is running studies. %@ is the app name (e.g. Firefox). */
"Settings.Studies.Message.v148" = "%@ randomly selects users to test features, which improves quality for everyone.";

/* Label used as a toggle item in Settings. When this is off, the user is opting out of all studies. */
"Settings.Studies.Title.v136" = "Install and Run Studies";

/* Label used as a toggle item in Settings. When this is off, the user is opting out of all studies. */
"Settings.Studies.Title.v148" = "Allow Feature Studies";

/* Title for a link that explains what Mozilla means by Rollouts */
"Settings.Rollouts.Link.v148" = "Learn More";

/* A short description that explains that Mozilla may change features remotely. %@ is the app name (e.g. Firefox). */
"Settings.Rollouts.Message.v148" = "%@ will improve features, performance, and stability between updates. Changes applied remotely.";

/* Label used as a toggle item in Settings. When this is off, the user is opting out of all rollouts. */
"Settings.Rollouts.Title.v148" = "Allow Remote Improvements";

/* This is the footer text for the setting that toggles the Summarize feature under the Summarize settings section. */
"Settings.Summarize.FooterTitle.v142" = "Provides access to summarize pages.";

Expand Down
19 changes: 18 additions & 1 deletion firefox-ios/Shared/Supporting Files/en-GB.lproj/Settings.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,12 +235,30 @@
/* Title for a link that explains what Mozilla means by Studies */
"Settings.Studies.Link.v136" = "Learn More";

/* Title for a link that explains what Mozilla means by Studies */
"Settings.Studies.Link.v148" = "Learn More";

/* A short description that explains that Mozilla is running studies */
"Settings.Studies.Message.v136" = "Try out features and ideas before they’re released to everyone.";

/* A short description that explains that Mozilla is running studies. %@ is the app name (e.g. Firefox). */
"Settings.Studies.Message.v148" = "%@ randomly selects users to test features, which improves quality for everyone.";

/* Label used as a toggle item in Settings. When this is off, the user is opting out of all studies. */
"Settings.Studies.Title.v136" = "Install and Run Studies";

/* Label used as a toggle item in Settings. When this is off, the user is opting out of all studies. */
"Settings.Studies.Title.v148" = "Allow Feature Studies";

/* Title for a link that explains what Mozilla means by Rollouts */
"Settings.Rollouts.Link.v148" = "Learn More";

/* A short description that explains that Mozilla may change features remotely. %@ is the app name (e.g. Firefox). */
"Settings.Rollouts.Message.v148" = "%@ will improve features, performance, and stability between updates. Changes applied remotely.";

/* Label used as a toggle item in Settings. When this is off, the user is opting out of all rollouts. */
"Settings.Rollouts.Title.v148" = "Allow Remote Improvements";

/* This is the footer text for the setting that toggles the Summarize feature under the Summarize settings section. */
"Settings.Summarize.FooterTitle.v142" = "Provides access to summarise pages.";

Expand Down Expand Up @@ -291,4 +309,3 @@

/* This is the title for the setting that toggles the Translation feature that allows users to translate web pages under the Translation settings section. */
"Settings.Translation.ToggleTitle.v145" = "Enable Translations";

24 changes: 22 additions & 2 deletions focus-ios/Blockzilla/UIComponents/UIConstants.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,14 @@ struct UIConstants {
static let labelBlockOther = NSLocalizedString("Settings.toggleBlockOther2", value: "Content", comment: "Label for the checkbox to toggle Other trackers")
static let labelBlockFonts = NSLocalizedString("Settings.toggleBlockFonts", value: "Block web fonts", comment: "Label for toggle on main screen")
static let labelSendAnonymousUsageData = NSLocalizedString("Settings.toggleSendUsageData", value: "Send usage data", comment: "Label for Send Usage Data toggle on main screen")
static let detailTextSendUsageData = NSLocalizedString("Settings.detailTextSendUsageData", value: "Mozilla strives to collect only what we need to provide and improve %@ for everyone.", comment: "Description associated to the Send Usage Data toggle on main screen. %@ is the app name (for example “Firefox Focus” or ”Firefox Klar”).")
static let detailTextSendUsageData = NSLocalizedString("Settings.detailTextSendUsageData", value: "Mozilla strives to collect only what we need to provide and improve %@ for everyone.", comment: "Description associated to the Send Usage Data toggle on main screen. %@ is the app name (for example \"Firefox Focus\" or \"Firefox Klar\").")
static let detailTextSendUsageDataV2 = NSLocalizedString("Settings.detailTextSendUsageData.v2", value: "Mozilla strives to collect only what we need to provide and improve %@ for everyone.", comment: "Description associated to the Send Usage Data toggle on main screen. %@ is the app name (for example \"Firefox Focus\" or \"Firefox Klar\").")
static let labelStudies = NSLocalizedString("Settings.toggleStudies", value: "Studies", comment: "Label for Studies toggle on the settings screen")
static let detailTextStudies = NSLocalizedString("Settings.detailTextStudies", value: "%@ may install and run studies from time to time.", comment: "Description associated to the Studies toggle on the settings screen. %@ is the app name (for example “Firefox Focus” or ”Firefox Klar”).")
static let detailTextStudies = NSLocalizedString("Settings.detailTextStudies", value: "%@ may install and run studies from time to time.", comment: "Description associated to the Studies toggle on the settings screen. %@ is the app name (for example \"Firefox Focus\" or \"Firefox Klar\").")
static let labelStudiesV2 = NSLocalizedString("Settings.toggleStudies.v2", value: "Allow Feature Studies", comment: "Label for Studies toggle on the settings screen")
static let detailTextStudiesV2 = NSLocalizedString("Settings.detailTextStudies.v2", value: "%@ randomly selects users to test features, which improves quality for everyone.", comment: "Description associated to the Studies toggle on the settings screen. %@ is the app name (for example \"Firefox Focus\" or \"Firefox Klar\").")
static let labelRollouts = NSLocalizedString("Settings.toggleRollouts", value: "Allow Remote Improvements", comment: "Label for Rollouts toggle on the settings screen")
static let detailTextRollouts = NSLocalizedString("Settings.detailTextRollouts", value: "%@ will improve features, performance, and stability between updates. Changes applied remotely.", comment: "Description associated to the Rollouts toggle on the settings screen. %@ is the app name (for example \"Firefox Focus\" or \"Firefox Klar\").")
static let labelCrashReports = NSLocalizedString(
"Settings.toggleCrashReports",
value: "Automatically Send Crash Reports",
Expand Down Expand Up @@ -408,4 +413,19 @@ struct UIConstants {
static let googleAmpURLPrefix = "https://www.google.com/amp/s/"
static let truncateLeader = "..."
}

// Helper class for formatting Study and Rollout settings text for display
class SettingsTextFormatter {
static let shared = SettingsTextFormatter()

private init() {}

func formatStudiesText(appName: String) -> String {
return String(format: strings.detailTextStudies, appName)
}

func formatRolloutsText(appName: String) -> String {
return String(format: strings.detailTextRollouts, appName)
}
}
}