[MTE-5047] - auto tests improvements #39
Open
+15
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request enables a previously skipped test ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
firefox-ios/firefox-ios-tests/Tests/XCUITests/BaseTestCase.swift (1)
463-472: Definespringboardbefore using it.
springboardisn’t defined in this file or this method, so this will not compile unless a global exists elsewhere. Safer to define it locally here.Proposed fix
pasteAction.waitAndTap() - springboard.buttons["Allow Paste"].tapIfExists(timeout: 0.5) + let springboard = XCUIApplication(bundleIdentifier: "com.apple.springboard") + springboard.buttons["Allow Paste"].tapIfExists(timeout: 0.5)firefox-ios/firefox-ios-tests/Tests/XCUITests/ShareLongPressTests.swift (1)
47-58: Renaming drops XCTest discovery.Methods without the
testprefix won’t run. If this is meant to stay as a test, rename it back or ensure test plans reference the new name explicitly.Proposed fix
- func verifyBookmarksShareNormalWebsiteReminders() { + func testBookmarksShareNormalWebsiteReminders() {
🤖 Fix all issues with AI agents
In `@firefox-ios/firefox-ios-tests/Tests/XCUITests/OnboardingTests.swift`:
- Around line 28-35: The tearDown currently returns early under iOS 17 and skips
essential cleanup; instead of returning, only skip the theme change: inside
tearDown keep the availability check and the condition using
self.name.contains("testSelectBottomPlacement") || iPad() to decide whether to
call switchThemeToDarkOrLight(theme: "Light"), but do not return — always call
app.terminate() and super.tearDown() after that block so cleanup runs regardless
of the theme gate.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
firefox-ios/firefox-ios-tests/Tests/AccessibilityTestPlan.xctestplanfirefox-ios/firefox-ios-tests/Tests/Smoketest.xctestplanfirefox-ios/firefox-ios-tests/Tests/TAESmokeTestPlan.xctestplanfirefox-ios/firefox-ios-tests/Tests/XCUITests/BaseTestCase.swiftfirefox-ios/firefox-ios-tests/Tests/XCUITests/OnboardingTests.swiftfirefox-ios/firefox-ios-tests/Tests/XCUITests/ShareLongPressTests.swift
💤 Files with no reviewable changes (3)
- firefox-ios/firefox-ios-tests/Tests/Smoketest.xctestplan
- firefox-ios/firefox-ios-tests/Tests/AccessibilityTestPlan.xctestplan
- firefox-ios/firefox-ios-tests/Tests/TAESmokeTestPlan.xctestplan
🧰 Additional context used
🧬 Code graph analysis (2)
firefox-ios/firefox-ios-tests/Tests/XCUITests/OnboardingTests.swift (1)
firefox-ios/firefox-ios-tests/Tests/XCUITests/BaseTestCase.swift (2)
iPad(357-362)switchThemeToDarkOrLight(439-461)
firefox-ios/firefox-ios-tests/Tests/XCUITests/ShareLongPressTests.swift (2)
firefox-ios/Client/Frontend/Library/LibraryPanelContextMenu.swift (1)
contextMenu(35-47)firefox-ios/firefox-ios-tests/Tests/XCUITests/BaseTestCase.swift (2)
pressWithRetry(651-669)waitAndTap(628-631)
🔇 Additional comments (2)
firefox-ios/firefox-ios-tests/Tests/XCUITests/OnboardingTests.swift (1)
347-352: LGTM: explicit iPad skip for bottom placement.firefox-ios/firefox-ios-tests/Tests/XCUITests/ShareLongPressTests.swift (1)
246-250: Nice stability improvement with context menu + retry.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Comment on lines
28
to
35
| if #available(iOS 17.0, *) { | ||
| switchThemeToDarkOrLight(theme: "Light") | ||
| if self.name.contains("testSelectBottomPlacement") || iPad() { | ||
| // Toolbar option not available for iPad, so the theme is not changed there. | ||
| return | ||
| } else { | ||
| switchThemeToDarkOrLight(theme: "Light") | ||
| } | ||
| } |
There was a problem hiding this comment.
Avoid early return in tearDown that skips cleanup.
On iOS 17, this returns before app.terminate() and super.tearDown(), which can leak state across tests. Gate only the theme switch, not the full teardown.
Proposed fix
override func tearDown() async throws {
if `#available`(iOS 17.0, *) {
- if self.name.contains("testSelectBottomPlacement") || iPad() {
- // Toolbar option not available for iPad, so the theme is not changed there.
- return
- } else {
- switchThemeToDarkOrLight(theme: "Light")
- }
+ if !(self.name.contains("testSelectBottomPlacement") || iPad()) {
+ switchThemeToDarkOrLight(theme: "Light")
+ }
}
app.terminate()
try await super.tearDown()
}🤖 Prompt for AI Agents
In `@firefox-ios/firefox-ios-tests/Tests/XCUITests/OnboardingTests.swift` around
lines 28 - 35, The tearDown currently returns early under iOS 17 and skips
essential cleanup; instead of returning, only skip the theme change: inside
tearDown keep the availability check and the condition using
self.name.contains("testSelectBottomPlacement") || iPad() to decide whether to
call switchThemeToDarkOrLight(theme: "Light"), but do not return — always call
app.terminate() and super.tearDown() after that block so cleanup runs regardless
of the theme gate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR from agentic-review-benchmarks#13
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.