EXP-5874 Add strings for Rollouts toggle and update Studies strings #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| private init() {} | ||
|
|
||
| func formatStudiesText(appName: String) -> String { | ||
| return String(format: strings.detailTextStudies, appName) |
There was a problem hiding this comment.
Helper class uses old string instead of new V2
Medium Severity
The newly added SettingsTextFormatter.formatStudiesText method uses strings.detailTextStudies (the old string with text "may install and run studies from time to time"), but this same PR adds detailTextStudiesV2 with the updated text ("randomly selects users to test features, which improves quality for everyone"). Given the PR's purpose is to update Studies strings, the formatter likely needs to reference detailTextStudiesV2 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#224
Note
Adds new user-facing copy for settings related to studies and remote improvements.
v148Studies (Title/Link/Message) and new Rollouts (Title/Link/Message) strings inShared/Strings.swiftand localizedSettings.stringsforen-CAanden-GBlabelStudies.v2,detailTextStudies.v2, and new Rollouts strings inUIConstants.swift; introduces a smallSettingsTextFormatterhelper to format Studies/Rollouts textfirefox-ios.xliff:Settings.Studies.Message.v148from quotes checksWritten by Cursor Bugbot for commit 8000f93. Configure here.