[MTE-5149] - delete auto tests #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| // Select Light mode | ||
| navigator.performAction(Action.SelectLightTheme) | ||
| let lightIsSelected = app.buttons[AccessibilityIdentifiers.Settings.Appearance.lightThemeView].value | ||
| let lightIsSelected = app.buttons[AccessibilityIdentifiers.Settings.Appearance.darkThemeView].value |
There was a problem hiding this comment.
Light theme assertion checks wrong theme view element
Medium Severity
In testCheckSystemThemeChanges(), after selecting the Light theme via Action.SelectLightTheme, the assertion checks darkThemeView.value instead of lightThemeView.value. The variable is named lightIsSelected but reads from the wrong UI element. This causes the test to verify the wrong theme selection state, making it either always fail or give a false positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#204
Note
Removes legacy UI tests and updates test stability/coverage.
ClipBoardTests/testCopyLink()andHomePageSettingsUITests/testSetCustomURLAsHome(); cleans up references acrossAccessibilityTestPlan.xctestplan,FullFunctionalTestPlan.xctestplan,Smoketest.xctestplan, andTAESmokeTestPlan.xctestplanClipBoardTests.swift, makescheckUrl(),copyUrl(), andcheckCopiedUrl()publicand stops invokingcheckCopiedUrl()intestClipboardDisplaySettingsTests.swift, correctstestCheckSystemThemeChangesassertion target and updates the case linkHomePageSettingsUITest.swift, removes the skipped custom URL test and adjusts navigation flow intestDisableTopSitesSettingsRemovesSection()Written by Cursor Bugbot for commit 83bd21c. Configure here.