Remove FXIOS-14327 [Clean up] Inactive tabs removal part 2 (final) #15
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| private func scrollToTab(_ scrollState: TabsPanelState.ScrollState) { | ||
| let section: Int = scrollState.isInactiveTabSection ? 0 : 1 | ||
| let indexPath = IndexPath(row: scrollState.toIndex, section: section) | ||
| let indexPath = IndexPath(row: scrollState.toIndex, section: 1) |
There was a problem hiding this comment.
Hardcoded section index is wrong after removing inactive tabs
High Severity
The scrollToTab method hardcodes section: 1 when creating the IndexPath, but since the inactive tabs section was removed, there's now only one section (.tabs) at index 0. This causes the scroll functionality to silently fail because the guard on line 176 will return early when isValid(indexPath:) returns false. The test files were correctly updated to use section 0 (e.g., _0_1 instead of _1_1), but this production code was not.
| // not contain a selected tab. In that case, we should scroll to the bottom of the panel. | ||
| // Note: Could optimize further by scrolling to the most recent tab if we had `lastExecutedTime` in our model | ||
| return ScrollState(toIndex: state.tabs.count - 1, isInactiveTabSection: false, withAnimation: shouldAnimate) | ||
| return ScrollState(toIndex: state.tabs.count, withAnimation: shouldAnimate) |
There was a problem hiding this comment.
Off-by-one error when scrolling to last tab
Medium Severity
The scroll-to-last-tab fallback uses state.tabs.count as the index, but array indices are 0-based, so this produces an out-of-bounds index. For example, with 3 tabs (indices 0, 1, 2), count returns 3 which is invalid. The original code used state.tabs.count - 1 which was correct. This causes the scroll to fail silently when switching tab panels with no selected tab.
Benchmark PR from qodo-benchmark#230
Note
Cursor Bugbot is generating a summary for commit f7001a1. Configure here.