Refactor FXIOS-14344 [Swift 6 migration] Fixing warnings in unit tests #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| XCTAssertTrue(self.center.requestAuthorizationWasCalled) | ||
| notificationManager.requestAuthorization { [center] (granted, error) in | ||
| assert(granted, "Authorization should be granted") | ||
| assert(center?.requestAuthorizationWasCalled ?? false, "requestAuthorization should be called") |
There was a problem hiding this comment.
Test uses assert instead of XCTAssertTrue
Medium Severity
The testRequestAuthorization test replaced XCTAssertTrue with Swift's assert() function. This is incorrect because assert() is stripped in optimized/release builds and doesn't integrate with XCTest—failures won't be reported as test failures, they'll either crash the process or be silently ignored. Every other test in this file correctly uses XCTAssertTrue and XCTAssertEqual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#236
Note
Swift 6 concurrency cleanup across unit tests and test mocks.
setUp/tearDownto async variants and callsuperwithawaitwhere needed@MainActorto many UI-driven test classes; adjust a few where not required@Sendableto closures and@unchecked Sendableto test mocks (e.g.,MockUserNotificationCenter,ClientSyncManagerSpy,MockTabQueue); mark some mocksfinalNotificationManagerTeststo use a capture list andassertchecksMockURLAuthenticationChallengeSenderfinal, MainActor/Sendable annotations on APIs)Written by Cursor Bugbot for commit ac31d8c. Configure here.