Remove FXIOS-14593 [BVC] Clean up qr code related code from BVC #19
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| windowUUID: state.windowUUID, | ||
| browserViewType: state.browserViewType, | ||
| displayView: .readerMode, | ||
| displayView: .readerModeLongPressAction, |
There was a problem hiding this comment.
Reader mode tap triggers wrong action after refactor
High Severity
The handleShowReaderModeAction function now sets displayView: .readerModeLongPressAction instead of displayView: .readerMode. This causes tapping the reader mode button to call toggleReaderModeLongPressAction() (which adds the page to reading list) instead of toggleReaderMode() (which enters/exits reader mode). Users will no longer be able to toggle reader mode via the button.
| case .available: true // will be enabled after action gets executed | ||
| default: false | ||
| case .available: false // will be enabled after action gets executed | ||
| default: true |
There was a problem hiding this comment.
Reader mode telemetry reports inverted enabled state
Medium Severity
The recordReaderModeTelemetry function inverts the isReaderModeEnabled value. When readerModeState is .available (meaning reader mode will be enabled after tap), the code now reports false. The comment still says "will be enabled after action gets executed" but the code does the opposite, causing telemetry to report incorrect reader mode usage data.
| var url = tabManager(for: windowUUID).selectedTab?.url | ||
| if let currentURL = url { | ||
| url = (currentURL.isWebPage() && !currentURL.isReaderModeURL) ? url : nil | ||
| url = (currentURL.isWebPage() || currentURL.isReaderModeURL) ? url : nil |
There was a problem hiding this comment.
URL handling logic inverted for reader mode pages
Medium Severity
The cancelEditMode URL filtering logic changed from (currentURL.isWebPage() && !currentURL.isReaderModeURL) to (currentURL.isWebPage() || currentURL.isReaderModeURL). The original code explicitly excluded reader mode URLs (setting them to nil), while the new code explicitly includes them. This behavioral change affects how the address bar displays when canceling edit mode on reader mode pages, and appears unrelated to the QR code cleanup purpose of this PR.
Benchmark PR from qodo-benchmark#206
Note
Removes the legacy QR code scanning feature and its integrations across the app.
Route.AppAction.showQRCode), andRouteBuilderhandlingGeneralBrowserActionType/BrowserViewControllerState.DisplayTypecases, plus related UI flow fromBrowserViewControllerToolbarTelemetry.qrCodeButtonTapped, Glean probestoolbar.qr_scan_button_tappedandqr_code.scanned) and correspondingTelemetryWrappermappingshandleShowReaderModeActionnow usesdisplayView: .readerModeLongPressAction; updates cancel-edit URL logic to include reader mode URLs and inverts reader mode telemetry flag logicAPP_VERSIONto147.2Written by Cursor Bugbot for commit 75b1c94. Configure here.