Skip to content

Conversation

@tomerqodo
Copy link

@tomerqodo tomerqodo commented Jan 20, 2026

Benchmark PR from qodo-benchmark#20


Note

Implements modal presentation for Privacy Notice links and wires end-to-end navigation.

  • Adds privacyNoticeLink(URL) destination and tapOnPrivacyNoticeLink action; reducer passes navigationDestination through; BVC routes to showPrivacyNoticeLink.
  • Extends BrowserNavigationHandler and BrowserCoordinator with showPrivacyNoticeLink(url:), presenting TermsOfUseLinkViewController full-screen.
  • Updates PrivacyNoticeCell to detect link taps (UITextViewDelegate) and expose linkAction; HomepageViewController dispatches navigation on link tap.
  • Adds unit tests for reducer navigation and coordinator presentation.

Written by Cursor Bugbot for commit 659442a. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

},
linkAction: { url in
self.dispatchPrivacyNoticeLinkTapped(url: url)
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing weak self capture causes potential retain cycle

Medium Severity

The linkAction closure in configurePrivacyNoticeCell captures self strongly, while the adjacent closeButtonAction closure correctly uses [weak self]. This creates a retain cycle: HomepageViewController → collection view → PrivacyNoticeCelllinkAction closure → HomepageViewController. The closure needs [weak self] and the call changed to self?.dispatchPrivacyNoticeLinkTapped(url: url).

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants