Skip to content

Conversation

@tomerqodo
Copy link

Benchmark PR mozilla-mobile#31253

Type: Clean (correct implementation)

Original PR Title: Refactor NO_TICKET Various improvements
Original PR Description: ## 📜 Tickets
Jira ticket
Github issue

💡 Description

Various improvements:

  • fixed spelling
  • updated comments and variable names
  • removed unused code
  • added a11y ids to BVC

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

Original PR URL: mozilla-mobile#31253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants