Skip to content

Conversation

@akirakyle
Copy link
Member

@akirakyle akirakyle commented Dec 9, 2024

Applies on top of #37 and #41, see #40 for discussion.

@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 11.48936% with 208 lines in your changes missing coverage. Please review.

Project coverage is 22.93%. Comparing base (46223c3) to head (371f36c).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/bases.jl 27.27% 56 Missing ⚠️
src/deprecated.jl 0.00% 51 Missing ⚠️
src/superoperators.jl 0.00% 39 Missing ⚠️
src/julia_base.jl 0.00% 30 Missing ⚠️
src/embed_permute.jl 0.00% 17 Missing ⚠️
src/expect_variance.jl 0.00% 11 Missing ⚠️
src/julia_linalg.jl 0.00% 3 Missing ⚠️
src/abstract_types.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   16.95%   22.93%   +5.97%     
==========================================
  Files          13       14       +1     
  Lines         401      484      +83     
==========================================
+ Hits           68      111      +43     
- Misses        333      373      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov
Copy link
Member

adding myself as a reviewer for after #37 and #41 are done

@akirakyle akirakyle marked this pull request as draft April 6, 2025 00:14
@akirakyle akirakyle force-pushed the bases-api-v2 branch 5 times, most recently from ab5cfe2 to ccc9e3c Compare April 7, 2025 18:32
@akirakyle akirakyle marked this pull request as ready for review April 7, 2025 18:34
@akirakyle akirakyle linked an issue Apr 7, 2025 that may be closed by this pull request
@akirakyle akirakyle force-pushed the bases-api-v2 branch 3 times, most recently from f948743 to 4ae8eef Compare April 9, 2025 05:08
@akirakyle akirakyle marked this pull request as draft April 16, 2025 16:08
@akirakyle akirakyle removed the request for review from Krastanov April 16, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC: Proposal for reworked basis sytem

2 participants