chore: Added more important instance statuses#237
Closed
MGSousa wants to merge 3 commits intoqonto:mainfrom
Closed
chore: Added more important instance statuses#237MGSousa wants to merge 3 commits intoqonto:mainfrom
MGSousa wants to merge 3 commits intoqonto:mainfrom
Conversation
Contributor
|
Thank you so much for this much needed contribution! Would it be possible for you to:
|
Signed-off-by: MGSousa <31368750+MGSousa@users.noreply.github.com>
MGSousa
force-pushed
the
add-more-instance-statuses
branch
from
bad07fd to
d034ce1
Compare
Signed-off-by: MGSousa <31368750+MGSousa@users.noreply.github.com>
qfritz
approved these changes
Jan 21, 2025
Contributor
qfritz
left a comment
qfritz
left a comment
There was a problem hiding this comment.
Minor suggestions but all the rest LGTM 👍
You may merge. Thanks again!
Signed-off-by: MGSousa <31368750+MGSousa@users.noreply.github.com>
Contributor
Author
|
I do not have push access to this repository to merge it, only maintainers have. |
qfritz
approved these changes
Jan 21, 2025
Contributor
|
I've signed off your commits for merging and will merge the branch here: #238 Thanks a lot for your contribution. I'll make sure to inform you when the tag is created (which should happen shortly). |
Contributor
|
Hi again, I'm happy to share that your changes are live in tag 0.11.0 🙇♀️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some important RDS statuses were missing (by default they always go as
unknown), adding these is necessary to be able to have better observability, prompt reaction, and the possibility to have custom metrics alerts.Added:
failed: when the DB instance has failed and AWS can't recover itstorage-full: when the DB instance has reached its storage capacity allocationrebooting: when the DB instance is performing a rebootupgrading: when the DB engine or OS version is being upgradedIt is also nice to have since any of these statuses may be an indication of a disruption to the RDS instance.