Skip to content

Comments

[CIT] Supported Datatypes (keys, values)#21

Closed
arkjedrz wants to merge 3 commits intomainfrom
ajedrzejewski_cit_datatypes
Closed

[CIT] Supported Datatypes (keys, values)#21
arkjedrz wants to merge 3 commits intomainfrom
ajedrzejewski_cit_datatypes

Conversation

@arkjedrz
Copy link

@arkjedrz arkjedrz commented Jul 7, 2025

Tests for:

  • Supported Datatypes (keys)
  • Supported Datatypes (values)

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 7d2b4ae6-9ec4-460a-a04a-b24cc053e845
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rules_boost~' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-aSViuHoOdF32Ue/Cx02/mOzyEebHMFuifjZs4GNWjsE="
DEBUG: Repository rules_boost~ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:387:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'googletest', the root module requires module version googletest@1.14.0, but got googletest@1.15.0 in the resolved dependency graph.
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.4.2 in the resolved dependency graph.
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Analyzing: target //:license-check (2 packages loaded, 0 targets configured)
Analyzing: target //:license-check (2 packages loaded, 0 targets configured)

Analyzing: target //:license-check (55 packages loaded, 10 targets configured)

Analyzing: target //:license-check (102 packages loaded, 10 targets configured)

Analyzing: target //:license-check (151 packages loaded, 856 targets configured)

Analyzing: target //:license-check (166 packages loaded, 1949 targets configured)

Analyzing: target //:license-check (170 packages loaded, 2895 targets configured)

Analyzing: target //:license-check (170 packages loaded, 2895 targets configured)

Analyzing: target //:license-check (170 packages loaded, 2895 targets configured)

Analyzing: target //:license-check (174 packages loaded, 5025 targets configured)

Analyzing: target //:license-check (175 packages loaded, 5145 targets configured)

Analyzing: target //:license-check (175 packages loaded, 5145 targets configured)

INFO: Analyzed target //:license-check (176 packages loaded, 7064 targets configured).
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:30:21: Generating Dash formatted dependency file ... failed: missing input file '//:cargo_lock'
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:30:21: Generating Dash formatted dependency file ... failed: 1 input file(s) do not exist
Target //:license.check.license_check failed to build
Use --verbose_failures to see the command lines of failed build steps.
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:30:21 Generating Dash formatted dependency file ... failed: 1 input file(s) do not exist
INFO: Elapsed time: 185.110s, Critical Path: 0.28s
INFO: 10 processes: 10 internal.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

The created documentation from the pull request is available at: docu-html

Copy link

@PiotrKorkus PiotrKorkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and clean

I would maybe add a case with negative number to make sure it will be also correctly converted to KvsValue and stored

@arkjedrz arkjedrz force-pushed the ajedrzejewski_cit_datatypes branch 2 times, most recently from 69b8f9a to 32a0236 Compare July 11, 2025 09:03
@arkjedrz arkjedrz requested a review from vinodreddy-g July 11, 2025 09:05
@arkjedrz arkjedrz force-pushed the ajedrzejewski_cit_datatypes branch from 32a0236 to 93e80ed Compare July 11, 2025 09:28
@arkjedrz arkjedrz force-pushed the ajedrzejewski_cit_datatypes branch from 93e80ed to e70ad5a Compare July 11, 2025 12:18
arkjedrz added 2 commits July 11, 2025 12:36
Applied automatic clippy fixes to decrease level of noisy warnings.
More flexible `get_value` implementation.
Previous version renamed to `get_value_as`.
@arkjedrz arkjedrz force-pushed the ajedrzejewski_cit_datatypes branch from e70ad5a to c11d432 Compare July 11, 2025 13:04
Tests checking if all required datatypes are supported.
@arkjedrz arkjedrz force-pushed the ajedrzejewski_cit_datatypes branch from c11d432 to f984398 Compare July 11, 2025 13:07
@arkjedrz arkjedrz closed this Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants