Closed
Conversation
This was referenced Jul 7, 2025
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
PiotrKorkus
approved these changes
Jul 7, 2025
PiotrKorkus
left a comment
There was a problem hiding this comment.
nice and clean
I would maybe add a case with negative number to make sure it will be also correctly converted to KvsValue and stored
69b8f9a to
32a0236
Compare
32a0236 to
93e80ed
Compare
93e80ed to
e70ad5a
Compare
Applied automatic clippy fixes to decrease level of noisy warnings.
More flexible `get_value` implementation. Previous version renamed to `get_value_as`.
e70ad5a to
c11d432
Compare
Tests checking if all required datatypes are supported.
c11d432 to
f984398
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for: