Conversation
|
Thank you very much for your contribution! We are still not quite done with all the legalese, but as soon as that is done we will merge your request. |
|
Thank you for your submission and apologies to have kept you waiting. |
|
I'll try to do it during the week, thanks! |
27c1dd9 to
9b4ad82
Compare
16e9615 to
09c184c
Compare
|
@lavonardo @Maddimax After some wrestling with the SSH keys I finally manage to sign commits again. I've updated the new SHAs for the plugin and the names/IDs inside. Thanks for the review! |
|
@lupax is this something you could also take a look? |
|
We have noticed that we have a showstopper with the legalese. If you have a look at 9. of Qt Creator Extensions Store Publisher Terms you would see:
@lavonardo any follow up in this regard? |
|
I see that now @cristianadam. Although I hold the license of GitQlient and it's plugin there are some files I need to remove to be able to change it since they are from another project. In any case, I'd have to take a look to those MIT/BSD/Apache licenses since just changing it for QtCreator is a no-go. Specially with the user base it has. A different story would be if QtCreator would support LGPL3 licenses, or similar where linking is allowed. |
Describe your changes
Adding GitQlient plugin to the extension registry.
Checklist
npm run allto validate my changes