Conversation
| override: bool = False, | ||
| baking_index: int = None, | ||
| sampling_rate: Union[int, float] = 1e9, | ||
| lf_2gsps: bool = False, |
There was a problem hiding this comment.
You already have a sampling rate parameter just above, why not use that (and check that if it's 2e9)
There was a problem hiding this comment.
The sampling_rate above was used in for the interpolation in voltage to achieve waveform shapes, I was thinking to preserve these two in to separate ways, and what about OPX+ compatibility? can that be checked by the baking function?
but I understand where you coming from to make it simple
There was a problem hiding this comment.
I would guess that you would need to deal with the sampling_rate anyhow when 2 GSPS is true, to define the waveforms correctly.
And currently, OPX+ will not support lf_2gsps=True, so in both cases there is something which is not supported.
We can decide whether to add a validation or not.
replace this template text
User requested to do cryoscope with lf-fem at the 2GSPS waveform shape and needed a small modification in the bakery to do so. Thus here I made the modification in object to achieve such effect
Remember to: