Skip to content

feature_2gsps#312

Open
KevinAVR wants to merge 1 commit intomainfrom
feature/bakery-2gsps
Open

feature_2gsps#312
KevinAVR wants to merge 1 commit intomainfrom
feature/bakery-2gsps

Conversation

@KevinAVR
Copy link
Copy Markdown
Contributor

replace this template text

User requested to do cryoscope with lf-fem at the 2GSPS waveform shape and needed a small modification in the bakery to do so. Thus here I made the modification in object to achieve such effect

Remember to:

  • Update the CHANGELOG.md
  • Added tests for the feature or fix

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 29, 2025

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit efca347.

♻️ This comment has been updated with latest results.

override: bool = False,
baking_index: int = None,
sampling_rate: Union[int, float] = 1e9,
lf_2gsps: bool = False,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already have a sampling rate parameter just above, why not use that (and check that if it's 2e9)

Copy link
Copy Markdown
Contributor Author

@KevinAVR KevinAVR Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sampling_rate above was used in for the interpolation in voltage to achieve waveform shapes, I was thinking to preserve these two in to separate ways, and what about OPX+ compatibility? can that be checked by the baking function?

but I understand where you coming from to make it simple

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess that you would need to deal with the sampling_rate anyhow when 2 GSPS is true, to define the waveforms correctly.
And currently, OPX+ will not support lf_2gsps=True, so in both cases there is something which is not supported.
We can decide whether to add a validation or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants