FIR filter fit function and description#320
Open
FabioAnsaloniQM wants to merge 9 commits intoqua-platform:mainfrom
Open
FIR filter fit function and description#320FabioAnsaloniQM wants to merge 9 commits intoqua-platform:mainfrom
FabioAnsaloniQM wants to merge 9 commits intoqua-platform:mainfrom
Conversation
File to implement IIR digital filters and corresponding readme file.
Co-authored-by: TheoLaudatQM <98808790+TheoLaudatQM@users.noreply.github.com>
Co-authored-by: TheoLaudatQM <98808790+TheoLaudatQM@users.noreply.github.com>
Co-authored-by: TheoLaudatQM <98808790+TheoLaudatQM@users.noreply.github.com>
Add files via upload
… an md file to explain how the fitting works and how to use them. Similar workflow as for the IIR filters.
Collaborator
|
@sebastianorbell-qm , you think we can break it to smaller PRs? |
Contributor
|
@OziEgri I would recommend splitting into two PR's
I think the file structure could be improved to by changing to something like this: Also removing the .DS_Store files and adding them to the .gitignore I would be happy to help review the PR's after. |
Author
|
@sebastianorbell-qm this sounds good to me. How should we move forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the fitting repo for FIR filter developed by Shlomi. Also added an .md file to explain how the fitting works and how to use it. Similar workflow as for the IIR filters