Skip to content

FIR filter fit function and description#320

Open
FabioAnsaloniQM wants to merge 9 commits intoqua-platform:mainfrom
FabioAnsaloniQM:main
Open

FIR filter fit function and description#320
FabioAnsaloniQM wants to merge 9 commits intoqua-platform:mainfrom
FabioAnsaloniQM:main

Conversation

@FabioAnsaloniQM
Copy link
Copy Markdown

Added the fitting repo for FIR filter developed by Shlomi. Also added an .md file to explain how the fitting works and how to use it. Similar workflow as for the IIR filters

FabioAnsaloniQM and others added 9 commits September 21, 2025 20:23
File to implement IIR digital filters and corresponding readme file.
Co-authored-by: TheoLaudatQM <98808790+TheoLaudatQM@users.noreply.github.com>
Co-authored-by: TheoLaudatQM <98808790+TheoLaudatQM@users.noreply.github.com>
Co-authored-by: TheoLaudatQM <98808790+TheoLaudatQM@users.noreply.github.com>
… an md file to explain how the fitting works and how to use them. Similar workflow as for the IIR filters.
@OziEgri
Copy link
Copy Markdown
Collaborator

OziEgri commented Jan 27, 2026

@sebastianorbell-qm , you think we can break it to smaller PRs?

@sebastianorbell-qm
Copy link
Copy Markdown
Contributor

sebastianorbell-qm commented Jan 27, 2026

@OziEgri I would recommend splitting into two PR's

  1. Documentation (including png's + .md files)
  2. Actual code contributions

I think the file structure could be improved to by changing to something like this:

qualang_tools/
│── filters/
│   |── __init__.py
│   |── iir.py
│   |── fir.py
│   |── README.md          # Combined filter documentation
|
|── docs/
│   |── images/
│       |── filters/
│           |── iir_step_response.png
│           |── fir_first_order.png
│           |── fir_second_order.png
│           |── fir_first_correction.png
│           |── fir_second_correction.png
|
── config/
│   |── ...                # configuration utilities

Also removing the .DS_Store files and adding them to the .gitignore

I would be happy to help review the PR's after.

@FabioAnsaloniQM
Copy link
Copy Markdown
Author

@sebastianorbell-qm this sounds good to me. How should we move forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants