Skip to content

Conversation

njjetha
Copy link

@njjetha njjetha commented Aug 11, 2025

Summary

qcom-preflight-checks calls a reusable-workflow that runs a series of preflight checks on your proposed contribution.

For more info check https://github.com/qualcomm/qcom-actions/blob/main/README.md

Substitute the repolinter workflow with a comprehensive set of
compliance and security checks. Project-specific exclusions are
supported for non-applicable validations. This update also introduces
a centrally-managed reusable workflow to streamline ongoing maintenance
and ensure consistency.

Signed-off-by: Neeraj Jetha <[email protected]>
@njjetha njjetha requested a review from mynameistechno August 11, 2025 06:40
@njjetha njjetha self-assigned this Aug 11, 2025
@ndechesne
Copy link

Please do not send push branch into this repo, instead use a forked tree to send pull request. We are not even supposed to have push/write access to the main repos.

exempt-issue-labels: bug,enhancement
exempt-pr-labels: bug,enhancement
days-before-stale: 30
days-before-close: 7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've experimented with 'closing' stale issues on meta-qcom, and we did not like it, and reverted see qualcomm-linux/meta-qcom@43bcad8. I would prefer to follow that here as well

@ricardosalveti
Copy link
Collaborator

Please do not send push branch into this repo, instead use a forked tree to send pull request. We are not even supposed to have push/write access to the main repos.

@mynameistechno we should probably revisit the default config for our repos and define a default branch protection rule to avoid new branches to be created this way.

@mynameistechno
Copy link
Contributor

mynameistechno commented Aug 12, 2025

@mynameistechno we should probably revisit the default config for our repos and define a default branch protection rule to avoid new branches to be created this way.

We could restrict branch creation except to users in a bypass list. @njjetha was most likely able to create the branch because he's a github admin, but it's very easy for a maintainer or anybody else to propose simple changes directly via the UI, so perhaps a rule should be added if we want to keep the branch namespace clean.

Do you want me to turn that on? I could use the maintainer team as the bypass list?

@ricardosalveti
Copy link
Collaborator

Do you want me to turn that on? I could use the maintainer team as the bypass list?

Yeah, I think this makes sense, +1 from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants