-
Notifications
You must be signed in to change notification settings - Fork 31
Conditionally enable virtualization packages in qcom-multimedia-image #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
One of the use cases we have for the multimedia-image is to be able to run the multimedia-related use cases in a container, so not sure if this separation is ideal here. I would just have it on both. |
|
Test teams agreed to pick container orchestration image for verifying the multimedia-related use cases inside a container. So testing part is covered.
|
Sure, but I still think docker (without kube* and family) is more useful in a generic way, and today people normally expect the standard distro image to have it.
Right, this is a different problem and we should try to identify ways to fix it, since we do expect to have go-lang based projects integrated by default here (we should not block golang simply because of region-specific access restrictions). |
Yes, agreed. In addition, we actually have features that depend on Docker enablement. |
Ok, understood. I updated the patch to bring in |
`docker-compose` and `packagegroup-container` are provided by the meta-virtualization layer. Guard their inclusion with `virtualization` DISTRO_FEATURE so they are omitted when users disable virtualization, preventing unnecessary dependencies from being pulled into the image. Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
Guard packages provided by meta-virtualization layer with
virtualizationDISTRO_FEATURE so they are omitted when users disable virtualization,
preventing unnecessary dependencies from being pulled into the image.