Skip to content

Conversation

@vkraleti
Copy link
Contributor

@vkraleti vkraleti commented Jan 14, 2026

Guard packages provided by meta-virtualization layer with virtualization
DISTRO_FEATURE so they are omitted when users disable virtualization,
preventing unnecessary dependencies from being pulled into the image.

koenkooi
koenkooi previously approved these changes Jan 14, 2026
@vkraleti vkraleti enabled auto-merge January 14, 2026 13:28
@ricardosalveti
Copy link
Contributor

One of the use cases we have for the multimedia-image is to be able to run the multimedia-related use cases in a container, so not sure if this separation is ideal here.

I would just have it on both.

@vkraleti
Copy link
Contributor Author

vkraleti commented Jan 15, 2026

Test teams agreed to pick container orchestration image for verifying the multimedia-related use cases inside a container. So testing part is covered.

docker‑compose pulls in Go projects hosted on Google cloud for compilation. Due to region‑specific access restrictions, these sources are not reachable in certain geographies. Since it is included in every image, users in these regions are currently unable to build anything. Dropping docker‑compose allows them to build the multimedia image without access restrictions.

@ricardosalveti
Copy link
Contributor

Test teams agreed to pick container orchestration image for verifying the multimedia-related use cases inside a container. So testing part is covered.

Sure, but I still think docker (without kube* and family) is more useful in a generic way, and today people normally expect the standard distro image to have it.

docker‑compose pulls in Go projects hosted on Google cloud for compilation. Due to region‑specific access restrictions, these sources are not reachable in certain geographies. Since it is included in every image, users in these regions are currently unable to build anything. Dropping docker‑compose allows them to build the multimedia image without access restrictions.

Right, this is a different problem and we should try to identify ways to fix it, since we do expect to have go-lang based projects integrated by default here (we should not block golang simply because of region-specific access restrictions).

@DapengYuan-David
Copy link

DapengYuan-David commented Jan 19, 2026

Sure, but I still think docker (without kube* and family) is more useful in a generic way, and today people normally expect the standard distro image to have it.

Yes, agreed. In addition, we actually have features that depend on Docker enablement.

@vkraleti
Copy link
Contributor Author

Sure, but I still think docker (without kube* and family) is more useful in a generic way, and today people normally expect the standard distro image to have it.

Yes, agreed. In addition, we actually have features that depend on Docker enablement.

Ok, understood. I updated the patch to bring in docker-compose with a feature check so that users have option to disable the distro feature to avoid it when needed.

`docker-compose` and `packagegroup-container` are provided by the
meta-virtualization layer. Guard their inclusion with `virtualization`
DISTRO_FEATURE so they are omitted when users disable virtualization,
preventing unnecessary dependencies from being pulled into the image.

Signed-off-by: Viswanath Kraleti <viswanath.kraleti@oss.qualcomm.com>
@vkraleti vkraleti changed the title Enable docker-compose in qcom-container-orchestration-image conditionally enable virtualization packages in qcom-multimedia-image Jan 20, 2026
@vkraleti vkraleti changed the title conditionally enable virtualization packages in qcom-multimedia-image Conditionally enable virtualization packages in qcom-multimedia-image Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants