Add irqbalance service to packagegroup-qcom #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apateriy-qcom
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
lumag
requested changes
Nov 19, 2025
Contributor
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
- Do you see any other commit having QCLINUX as a prefix? What do other commits have there?
- IRQbalance is considered to be a bad idea: https://konkor.github.io/cpufreq/faq/#irqbalance-detected. Are we sure that we want to enable it?
irqbalance distributes hardware interrupts across processors to improve system performance. Signed-off-by: Anurag Pateriya <[email protected]>
apateriy-qcom
changed the title
| tinyalsa \ | ||
| trace-cmd \ | ||
| usbutils \ | ||
| irqbalance \ |
Contributor
|
I'll echo @lumag: how was irqbalance tested? Everytime I tested in the past, it turned out to be a net detriment to overall performance. Especially in situations on Arm SoCs with multiple clusters (e.g. AMD Seattle) or heterogeneous cores irqbalance does the wrong thing. And that was in situations where both the PPTT ACPI tables as well as the MPIDR register provided the correct topology, which turns out to be a rare thing in Arm land. At the very least the commit message needs to say which tests were run (and how) and show before/after numbers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
irqbalance distributes hardware interrupts across processors to improve system performance.