Fix errors when building with an alternative libc than glibc #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it ends up failed when building with an alternative libc such as musl. Signed-off-by: Jaeyoon Jung <[email protected]>
lumag
requested changes
Nov 23, 2025
Contributor
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
This needs to go to OE-Core instead.
Contributor
Hmm, or not. Please ignore my comment. |
lumag
approved these changes
Nov 23, 2025
koenkooi
approved these changes
Nov 24, 2025
It's unnecessary and redundant as BASE_DEFAULT_DEPS already has virtual/libc, and causing an error when building with an alternative libc implementation such as musl. Signed-off-by: Jaeyoon Jung <[email protected]>
Author
|
Added one more commit 284edd9 |
Contributor
Can you update update the PR title acording, removing the bluez5_%.bbappend given that PR is more extensive. |
jaeyoonjung
changed the title
Backports the commit 300f7b5c0d5e223441e4687113d55d4350859f9e from upstream. Signed-off-by: Jaeyoon Jung <[email protected]>
Signed-off-by: Jaeyoon Jung <[email protected]>
Remove __unused macro and use __attribute__((unused)) instead. Use -1 instead of NULL for SOCKET type. Signed-off-by: Jaeyoon Jung <[email protected]>
Have HAVE_SYS_SOCKET_H defined by configure. Signed-off-by: Jaeyoon Jung <[email protected]>
Remove __unused macro and use __attribute__((unused)) instead. '#include <unistd.h>' is needed by 'usleep' and 'close'. Signed-off-by: Jaeyoon Jung <[email protected]>
|
@jaeyoonjung thanks for submitting this PR. Since this branch is not yet accepting changes directly via GitHub, will raise this issue internally, get changes accepted there. |
Add missing function declarations. Have HAVE_SYS_SOCKET_H defined by configure. Signed-off-by: Jaeyoon Jung <[email protected]>
Have HAVE_SYS_SOCKET_H defined by configure. Signed-off-by: Jaeyoon Jung <[email protected]>
Remove __unused macro. Use 0 over NULL for int type. Signed-off-by: Jaeyoon Jung <[email protected]>
Author
Alright. I've added one more set of commits, which seems to be the last I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it ends up failed when building with an alternative libc such as musl.