Rb3gen2: Add support for Open Boot firmware (TF-A, OP-TEE and U-Boot) build #1172
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,13 @@ | ||
| SRC_URI += "https://github.com/coreboot/qc_blobs/raw/refs/heads/master/sc7280/qtiseclib/libqtisec.a;name=qtiseclib" | ||
| SRC_URI[qtiseclib.sha256sum] = "6860dda0701c8709530608cc0e5a61b76484ae16cb673ba9a23510cf4b3d57bf" | ||
|
|
||
| DEPENDS += "optee-os" | ||
|
|
||
| COMPATIBLE_MACHINE = "qcm6490" | ||
| TFA_PLATFORM = "rb3gen2" | ||
| TFA_BUILD_TARGET = "bl2 fip" | ||
| TFA_SPD = "opteed" | ||
| EXTRA_OEMAKE:append = " \ | ||
| QTISECLIB_PATH=${UNPACKDIR}/libqtisec.a \ | ||
| BL32=${RECIPE_SYSROOT}/${nonarch_base_libdir}/firmware/tee-raw.bin \ | ||
|
Contributor
There was a problem hiding this comment. If you change the order of the commits, you won't have to change the file that you have just added.
Member
Author
There was a problem hiding this comment. This commit adds OP-TEE support to the TF-A recipe added by previous commit. So, I am not sure what do you meant by reordering commits here.
Contributor
There was a problem hiding this comment.
|
||
| " | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # RB3Gen2 specific OP-TEE support | ||
|
|
||
| require optee-os-qcom.inc | ||
|
|
||
| COMPATIBLE_MACHINE = "qcm6490" | ||
| OPTEEMACHINE = "qcom-kodiak" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| SRCBRANCH = "qcom-next" | ||
|
|
||
| SRC_URI = "git://github.com/qualcomm-linux/optee_os.git;protocol=https;name=optee;branch=${SRCBRANCH}" | ||
| SRCREV_optee = "a427f12bc60e74ccdd2ae771b50ed237397a0782" | ||
|
Contributor
There was a problem hiding this comment. The same question. We rewrite SRC_URI and SRCREV here. It breaks user assumptions. |
||
b49020 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| MACHINE_OPTEE_OS_TADEVKIT_REQUIRE ?= "" | ||
| MACHINE_OPTEE_OS_TADEVKIT_REQUIRE:qcm6490 = "optee-os-qcm6490.inc" | ||
|
|
||
| require ${MACHINE_OPTEE_OS_TADEVKIT_REQUIRE} |
b49020 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| MACHINE_OPTEE_OS_REQUIRE ?= "" | ||
| MACHINE_OPTEE_OS_REQUIRE:qcm6490 = "optee-os-qcm6490.inc" | ||
|
|
||
| require ${MACHINE_OPTEE_OS_REQUIRE} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # qcm6490 specific configuration | ||
|
|
||
| COMPATIBLE_MACHINE = "qcm6490" | ||
ricardosalveti marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Machine specific configurations | ||
|
|
||
| MACHINE_OPTEE_TEST_REQUIRE ?= "" | ||
| MACHINE_OPTEE_TEST_REQUIRE:qcm6490 = "optee-test-qcm6490.inc" | ||
|
|
||
| require ${MACHINE_OPTEE_TEST_REQUIRE} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| SUMMARY = "Packages for the OP-TEE support" | ||
|
|
||
| inherit packagegroup | ||
|
|
||
| RRECOMMENDS:${PN} = " \ | ||
| ${@bb.utils.contains('MACHINE_FEATURES', 'optee', 'optee-client', '', d)} \ | ||
| ${@bb.utils.contains('MACHINE_FEATURES', 'optee', 'optee-test', '', d)} \ | ||
| ${@bb.utils.contains('MACHINE_FEATURES', 'optee', 'optee-os-ta', '', d)} \ | ||
|
Contributor
There was a problem hiding this comment. Why do we need three lines here?
Member
Author
There was a problem hiding this comment. Okay, I will convert them in a single line. |
||
| " | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the licence for the blob? Does it change the licence of the generated binary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license for this blob can be found here: https://github.com/coreboot/qc_blobs/blob/master/sc7280/qtiseclib/LICENSE.
AFAIK, it doesn't change the overall TF-A project license but rather it is required for the binary components to be compliant with the TF-A license terms, see here: https://trustedfirmware-a.readthedocs.io/en/latest/process/contributing.html#binary-components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still the licence should be included in SBOM, etc., so it should be properly annotated.
Also we have to comply to the licensing terms. E.g.: