Hamoa IoT EVK support #1211
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Copyright (c) 2023 Qualcomm Technologies, Inc. | ||
| All Rights Reserved. | ||
| Confidential and Proprietary - Qualcomm Technologies, Inc. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| DESCRIPTION = "QCOM NHLOS Firmware for Qualcomm IQ-X7181 platform" | ||
| LICENSE = "Proprietary" | ||
|
|
||
| # Speicify the license in recipe folder, it will be part of tarball for hamoa sprint2 release. | ||
|
Contributor
There was a problem hiding this comment. What does that mean? I don't know what is sprint2 nor what are the expected release dates. Please think about out-of-context people reading the patch. |
||
| LIC_FILES_CHKSUM = "file://${THISDIR}/files/license/Qualcomm-Technologies-Inc.-Proprietary;md5=58d50a3d36f27f1a1e6089308a49b403" | ||
|
Contributor
There was a problem hiding this comment. Nope. It must a be a checksum of the file inside the "source". Checksumming a file outside of the source tree makes zero sense. If you want to checksum something, checksum the library. At least we know that it will change for the next release. |
||
|
|
||
| BOOTBINARIES = "IQ-X.1.0-Ver.${PV}-ubuntu-X1E80100-nhlos-bins" | ||
| S = "${UNPACKDIR}/${BOOTBINARIES}/spinor" | ||
|
|
||
| SRC_URI = " \ | ||
| https://artifacts.codelinaro.org/artifactory/qli-ci/flashable-binaries/ubuntu-fw/X1E80100/IQ-X.1.0-Ver.${PV}/IQ-X.1.0-Ver.${PV}-ubuntu-X1E80100-nhlos-bins.tar.gz;downloadfilename=${BOOTBINARIES}.tar.gz;name=bootbinaries \ | ||
| https://artifacts.codelinaro.org/artifactory/codelinaro-le/Qualcomm_Linux/X1E80100/cdt/IQ-X.1.0-EVK-CDT.tar.gz;downloadfilename=cdt-iq-x7181-evk_${PV}.tar.gz;name=iq-x7181-evk \ | ||
|
|
||
| " | ||
| SRC_URI[iq-x7181-evk.sha256sum] = "d55cfc97c810582cdfc88c77b0fbe516cd77468ea40ab88f7e0cd53cadd9df12" | ||
|
|
||
| QCOM_BOOT_IMG_SUBDIR = "iq-x7181/spinor" | ||
|
|
||
| include firmware-qcom-boot-common.inc | ||
|
|
||
| do_deploy:append() { | ||
lumag marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| find "${S}" -maxdepth 1 -name '*.xml' -exec install -m 0644 {} ${DEPLOYDIR}/${QCOM_BOOT_IMG_SUBDIR} \; | ||
|
Contributor
There was a problem hiding this comment. Nope, no partition files, please. |
||
| find "${S}" -maxdepth 1 -name '*.lzma' -exec install -m 0644 {} ${DEPLOYDIR}/${QCOM_BOOT_IMG_SUBDIR} \; | ||
|
Contributor
There was a problem hiding this comment. Be precise here, list
Contributor
Author
There was a problem hiding this comment.
|
||
| find "${S}" -maxdepth 1 -name '*.xz' -exec install -m 0644 {} ${DEPLOYDIR}/${QCOM_BOOT_IMG_SUBDIR} \; | ||
|
|
||
| find "${S}" -maxdepth 1 -type f -name 'xbl_s_devprg_ns.melf' -exec install -m 0644 {} ${DEPLOYDIR}/${QCOM_BOOT_FILES_SUBDIR} \; | ||
|
Contributor
There was a problem hiding this comment. I believe we can probably add '.lzma', '.xz' and '*.melf' directly in recipes-bsp/firmware-boot/firmware-qcom-boot-common.inc. We just don't want .xml there by default as we prefer to generate those with qcom-ptool.
Contributor
There was a problem hiding this comment. The scope for QCOM_BOOT_FILES_SUBDIR is at image_types_qcom.bbclass (initially set there), and the local variable is actually QCOM_BOOT_IMG_SUBDIR, but you would have to drop spinor out of it.
Contributor
There was a problem hiding this comment. This is totally unnecessary, the melf files are handled in
Contributor
Author
There was a problem hiding this comment. In firmware-qcom-boot-common.inc, it will install .melf (include programmer) to spinor subfolder. previous commit I made a copy of programmer in image_types_qcom.bbclass, looks there is still concern. which recipe do you think we need to install a programmer copy to support flash build for nvme ?
Contributor
There was a problem hiding this comment. The same programer will be needed with spinor, nvme and ufs, right? You could handle that in image_types_qcom (as I said, the scope of QCOM_BOOT_FILES_SUBDIR is already outside this file).
Contributor
There was a problem hiding this comment. I asked for this change. The sharing of SPINOR programmer for NVMe works for this platform, but I don't want to impose such dependencies in a generic code. |
||
| find "${UNPACKDIR}" -name '*CDT.bin' -exec install -m 0644 {} ${DEPLOYDIR}/${QCOM_BOOT_IMG_SUBDIR} \; | ||
|
Contributor
There was a problem hiding this comment. Rename the file in the do_compile stage rather than adding extra commands here. |
||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| require firmware-qcom-boot-iq-x7181.inc | ||
|
|
||
| SRC_URI[bootbinaries.sha256sum] = "8a2ab2f320995a4e89511218a1e81f8811f264f5881ebcedc601b26706858fb5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really add much, I know it is the same content as used by the other boot firmware blobs, but there this file is at least part of the tarball (and it will be updated with the correct license at some point).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not enough at all. It doesn't define any terms or conditions. Please use an actual licence.