Bluetooth: Add Bluetooth BD address setup service and script #1212

quicjathot · 2025-11-14T07:10:01Z

If controller returns Bluetooth Device Address (BDA) which is not unique then device will set to unconfigured state, Hence add qca_set_bdaddr.service and qca_set_bdaddr.sh to configure a unique BDA on boot.
Add bluez5_%.bbappend to:
- Include the new service and script in the BlueZ5 recipe.
- Include obex to support obex related profiles like OPP, FTP, MAP, PBAP
- Include only desired tools that are conditional on READLINE in bluez
- Install the script to /etc/initscripts and the systemd unit to bluetooth.target.wants.

- If controller returns Bluetooth Device Address (BDA) which is not unique then device will set to unconfigured state, Hence add `qca_set_bdaddr.service` and `qca_set_bdaddr.sh` to configure a unique BDA on boot. - Add `bluez5_%.bbappend` to: - Include the new service and script in the BlueZ5 recipe. - Include obex to support obex related profiles like OPP, FTP, MAP, PBAP - Include only desired tools that are conditional on READLINE in bluez - Install the script to `/etc/initscripts` and the systemd unit to `bluetooth.target.wants`. Signed-off-by: Janaki Ramaiah Thota <[email protected]>

koenkooi

This seems an invasive enough change to be its own recipe and perhaps a bluez.bbappend to add the stand alone recipe to RRECOMMENDS.

koenkooi · 2025-11-14T07:50:42Z

recipes-connectivity/bluez5/bluez5_%.bbappend

+    install -d ${D}${sysconfdir}/initscripts
+    install -m 755 ${UNPACKDIR}/qca_set_bdaddr.sh ${D}${sysconfdir}/initscripts/
+
+    # Install service that will run qca_set_bdaddr.sh script on boot


systemd.bbclass should be enabling this by default already:

# Whether to enable or disable the services on installation. SYSTEMD_AUTO_ENABLE ??= "enable" [...] if [ "${SYSTEMD_AUTO_ENABLE}" = "enable" ]; then for service in ${@systemd_filter_services("${SYSTEMD_SERVICE_ESCAPED}", False, d)}; do systemctl ${OPTS} enable "$service" done for service in ${@systemd_filter_services("${SYSTEMD_SERVICE_ESCAPED}", True, d)}; do systemctl --global ${OPTS} enable "$service" done fi

will reuse these SYSTEMD_AUTO_ENABLE.

koenkooi · 2025-11-14T07:52:59Z

recipes-connectivity/bluez5/bluez5_%.bbappend

+
+FILESEXTRAPATHS:prepend := "${THISDIR}/${BPN}:"
+
+RRECOMMENDS:${PN} += " \


Please keep variables sorted by usage, so R* goes below do_install, SRC* goes above do_unpack, configure vars go right above do_configure and installation vars go right above do_install.

Thanks for the guidance. will reorder variables accordingly

koenkooi · 2025-11-14T07:53:32Z

recipes-connectivity/bluez5/bluez5/qca_set_bdaddr.sh

+# SPDX-License-Identifier: BSD-3-Clause-Clear
+
+# Function to format BD-Address and Set it
+set_bda() {


There's zero error checking and handling in this method

sure will will error checking for each command.

the entire script actually

lumag

Also please don't describe patch contents in the commit message. Describe oly rationale and what is done to solve that.

lumag · 2025-11-14T10:26:53Z

recipes-connectivity/bluez5/bluez5/qca_set_bdaddr.sh

+    formatted_serial_number=$(echo "${hex_serial_number}" | sed 's/../&:/g;s/:$//')
+
+    # Append qualcomm general prefix BDA value 22:22
+    BDA=22:22:${formatted_serial_number:0:14}


Bashism, will not work with posix shells

Also, where does 22:22 come from?

we took android HAL code as reference for this

Don't take random unreliable sources. There are standards, owners, etc.

lumag · 2025-11-14T10:28:23Z

recipes-connectivity/bluez5/bluez5/qca_set_bdaddr.sh

+    {
+        echo "public-addr $BDA"
+        sleep 1
+    } | btmgmt


Why is it so complex? btmgmt --index 0 public-addr ${addr}

Since btmgmt is interactive it is actually stuck If we directly use the command during boot in script . With above approach everytime it is working and it is not getting stuck.

Please read carefully what I wrote.

lumag · 2025-11-14T10:28:54Z

recipes-connectivity/bluez5/bluez5/qca_set_bdaddr.sh

+        elif  [[ "$unconfigured" == "DOWN RAW" ]]; then
+           break
+        elif [[ "$configured" == "DOWN" ]]; then
+           echo "BD-Address already configured!!"


No need to say anything if it works as expected.

noisy success messages Understood. will remove success prints

lumag · 2025-11-14T10:29:30Z

recipes-connectivity/bluez5/bluez5_%.bbappend

+
+RRECOMMENDS:${PN} += " \
+    glibc-gconv-utf-16 \
+    glibc-gconv-utf-32 \


Please add a comment, why do you need these

will handle in different recipe and PR with updated the comment

lumag · 2025-11-14T10:30:28Z

recipes-connectivity/bluez5/bluez5_%.bbappend

+"
+
+#Include obex to support obex related profiles like OPP, FTP, MAP, PBAP
+RDEPENDS:${PN} += "${PN}-obex"


This is unrelated. In general, such things should be split into separate commits. In this particular case it should be solved by the distro layer instead by pulling the right set of packages.

Sure, will pull the commit changes related to obex tools to separate commit and PR

lumag · 2025-11-14T10:30:54Z

recipes-connectivity/bluez5/bluez5_%.bbappend

+#Remove desired tools from noinst-tools
+NOINST_TOOLS:remove = " \
+    ${@bb.utils.contains('PACKAGECONFIG', 'readline', '${INST_TOOLS_READLINE}', '', d)} \
+"


Separate commit with a proper explanation

sure, will handle in different PR

lumag · 2025-11-14T10:31:21Z

recipes-connectivity/bluez5/bluez5_%.bbappend

+    #Install desired tools that upstream leaves in build area
+    for f in ${INST_TOOLS_READLINE} ; do
+        install -m 755 ${B}/$f ${D}/${bindir}
+    done


This should be patched in the upstream or in OE-Core

quicjathot · 2025-11-17T14:54:24Z

This seems an invasive enough change to be its own recipe and perhaps a bluez.bbappend to add the stand alone recipe to RRECOMMENDS.

Thanks! Agreed, will move the script and unit into a new recipe (qca-bt-bdaddr) and keep bluez5_%.bbappend separate. This keeps BlueZ packaging untouched and scopes the change properly.

quicjathot · 2025-11-17T16:06:35Z

Also please don't describe patch contents in the commit message. Describe oly rationale and what is done to solve that.

ok, will rework on the commit message scope and updated

ricardosalveti · 2025-11-17T21:56:58Z

recipes-connectivity/bluez5/bluez5/qca_set_bdaddr.service

@@ -0,0 +1,12 @@
+[Unit]
+Description=start set BDA script for bluetooth


Please improve the description.

sure, noted.

ricardosalveti · 2025-11-17T21:58:02Z

recipes-connectivity/bluez5/bluez5/qca_set_bdaddr.service

+
+[Service]
+Type=simple
+ExecStart=+/etc/initscripts/qca_set_bdaddr.sh


nack, script should be an executable available in /usr/bin

Or ${sbindir}.

ricardosalveti · 2025-11-18T00:27:57Z

recipes-connectivity/bluez5/bluez5/qca_set_bdaddr.sh

+
+# Function to check BD Address and wait until it becomes configured or unconfigured
+validate_and_set_bda() {
+    while true; do


I would prefer a fixed set of runs here, probably trying the loop for up to 5 times with a sleep 1 or similar between runs, no need for while true.

sure , will consider and update the iteration based on the results

ricardosalveti · 2025-11-18T00:29:42Z

recipes-connectivity/bluez5/bluez5_%.bbappend

@@ -0,0 +1,52 @@
+inherit systemd


Please create a different recipe for this, it needs bluez but there is no need to be part of it.

quicjathot requested review from lumag, ndechesne, ricardosalveti, sbanerjee-quic and vkraleti as code owners November 14, 2025 07:10

koenkooi requested changes Nov 14, 2025

View reviewed changes

lumag requested changes Nov 14, 2025

View reviewed changes

ricardosalveti reviewed Nov 17, 2025

View reviewed changes

ricardosalveti reviewed Nov 18, 2025

View reviewed changes


		FILESEXTRAPATHS:prepend := "${THISDIR}/${BPN}:"

		RRECOMMENDS:${PN} += " \

		@@ -0,0 +1,12 @@
		[Unit]
		Description=start set BDA script for bluetooth

Bluetooth: Add Bluetooth BD address setup service and script #1212

Are you sure you want to change the base?

Bluetooth: Add Bluetooth BD address setup service and script #1212

Uh oh!

Conversation

quicjathot commented Nov 14, 2025

Uh oh!

koenkooi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lumag left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quicjathot commented Nov 17, 2025

Uh oh!

quicjathot commented Nov 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels