-
Notifications
You must be signed in to change notification settings - Fork 218
msm-gbm-backend: rename GBM backend library from msm_gbm to msm-kms_gbm #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yashgupta2126
wants to merge
1
commit into
qualcomm-linux:master
Choose a base branch
from
yashgupta2126:msm-backend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
46 changes: 46 additions & 0 deletions
46
...ics/msm-gbm-backend/files/0004-QCOM-libgbm-rename-GBM-backend-library-from-msm_gbm-.patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| From 6dc20b5b7c4e37443935107d2b14a0444964a4ac Mon Sep 17 00:00:00 2001 | ||
| From: Yash Gupta <quic_ygupt@quicinc.com> | ||
| Date: Wed, 4 Mar 2026 22:39:55 +0530 | ||
| Subject: [PATCH] QCOM:libgbm: add support for both 'msm' and 'msm-kms' GBM | ||
| backend names | ||
|
|
||
| The MSM DRM subsystem now exposes two driver names: 'msm' (legacy | ||
| combined GPU+KMS driver) and 'msm-kms' (new KMS-only driver used on | ||
| KGSL-based platforms). Mesa's GBM backend auto-detection looks for | ||
| '<drm_driver_name>_gbm.so', so both names must be resolvable. | ||
|
|
||
| Build the library as 'msm-kms_gbm.so' and install a compatibility | ||
| symlink 'msm_gbm.so -> msm-kms_gbm.so' so that both driver names | ||
| resolve to the correct MSM GBM backend without requiring the | ||
| GBM_BACKEND environment variable to be set explicitly. | ||
|
|
||
| Signed-off-by: Yash Gupta <quic_ygupt@quicinc.com> | ||
| Upstream-Status: Pending | ||
| --- | ||
| src/meson.build | 6 +++++- | ||
| 1 file changed, 5 insertions(+), 1 deletion(-) | ||
|
|
||
| diff --git a/src/meson.build b/src/meson.build | ||
| index f94d665..ec0d1d1 100644 | ||
| --- a/src/meson.build | ||
| +++ b/src/meson.build | ||
| @@ -22,7 +22,7 @@ src = [ | ||
| 'schema_parser.h', | ||
| ] | ||
|
|
||
| -msm_gbm = library('msm_gbm', | ||
| +msm_gbm = library('msm-kms_gbm', | ||
| src, | ||
| dependencies : [ | ||
| gbm, | ||
| @@ -44,3 +44,7 @@ install_data( | ||
| ) | ||
|
|
||
| install_headers('gbm_msm.h') | ||
| + | ||
| +meson.add_install_script('sh', '-c', | ||
| + 'ln -sf msm-kms_gbm.so "$MESON_INSTALL_DESTDIR_PREFIX/lib/gbm/msm_gbm.so"' | ||
| +) | ||
| -- | ||
| 2.34.1 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we patching a repository we maintain?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repository is shared between ubuntu deliverable in 6.8 kernel and mainline deliverable in 6.18+ kernel. The driver's name has changed with 'commit id 217ed15bd399980981f90f4332bc7ad4b05baa7e' in latest kernel version. Thus, raising a patch for mainline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, NAK from my side, mainline should contain the latest changes as part of the repo (as part of a mainline / master / trunk branch), if we need to use an older rev / branch for ubuntu, then manage that separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember this will also later be used with debian and other distros (@lool fyi).