Skip to content

Fix zizmor findings #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anujm1 wants to merge 2 commits into
base: master
Choose a base branch
from
+35 −18
Open

Fix zizmor findings #1688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
324734e
ci: use at least v6 of checkout action in workflows
anujm1 Mar 5, 2026
82eebe6
ci: pin all GitHub actions by hash
anujm1 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/actions/lava-test-plans/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ inputs:
runs:
using: "composite"
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
persist-credentials: false
repository: qualcomm-linux/lava-test-plans
path: lava-test-plans
ref: 1ab5e2f1d6cc3559ca4685941cc9fd17ab132c2d
Expand Down
16 changes: 12 additions & 4 deletions .github/workflows/build-yocto.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ jobs:
wget -qO ${KAS_CONTAINER} https://raw.githubusercontent.com/siemens/kas/refs/tags/$LATEST/kas-container
chmod +x ${KAS_CONTAINER}

- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
persist-credentials: false

- name: Run kas lock
run: |
Expand All @@ -57,7 +59,9 @@ jobs:
if: github.repository_owner == 'qualcomm-linux'
runs-on: [self-hosted, qcom-u2404, amd64]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
persist-credentials: false

- name: Download kas lockfile
uses: actions/download-artifact@v7
Expand Down Expand Up @@ -116,7 +120,9 @@ jobs:
yamlfile: ":ci/linux-qcom-rt-6.18.yml:ci/qcom-distro-kvm.yml"
name: ${{ matrix.machine }}/${{ matrix.distro.name }}${{ matrix.kernel.dirname }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
persist-credentials: false

- name: Run kas build
uses: ./.github/actions/compile
Expand Down Expand Up @@ -245,7 +251,9 @@ jobs:
yamlfile: ""
name: ${{ matrix.machine }}/${{ matrix.distro.name }}${{ matrix.kernel.dirname }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
persist-credentials: false

- name: Run kas build
uses: ./.github/actions/compile
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-results.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
private-key: ${{ secrets.TEST_REPORTING_APP_TOKEN }}

- name: Publish Test Results
uses: EnricoMi/publish-unit-test-result-action@v2
uses: EnricoMi/publish-unit-test-result-action@c950f6fb443cb5af20a377fd0dfaa78838901040 # v2.23.0
if: |
always()
&& contains(steps.listfiles.outcome, 'success')
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/repolinter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,22 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
persist-credentials: false

- name: Verify repolinter config file is present
id: check_files
uses: andstor/file-existence-action@v3
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3
with:
files: "repolint.json"
- name: Run Repolinter with local repolint.json
if: steps.check_files.outputs.files_exists == 'true'
uses: todogroup/repolinter-action@v1
uses: todogroup/repolinter-action@4d478dcd860571382da7d512d6dc6dd5f554fbb2 # v1.7.3
with:
config_file: "repolint.json"
- name: Run Repolinter with default ruleset
if: steps.check_files.outputs.files_exists == 'false'
uses: todogroup/repolinter-action@v1
uses: todogroup/repolinter-action@4d478dcd860571382da7d512d6dc6dd5f554fbb2 # v1.7.3
with:
config_url: "https://raw.githubusercontent.com/quic/.github/main/repolint.json"
2 changes: 1 addition & 1 deletion .github/workflows/test-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
echo "pr_number=$PR_NUMBER" >> $GITHUB_OUTPUT

- name: Comment on PR
uses: thollander/actions-comment-pull-request@v3
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3
with:
file-path: pr-comment.txt
pr-number: ${{ steps.pr_comment_prep.outputs.pr_number }}
Expand Down
19 changes: 12 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@ jobs:
- machine: qcom-armv7a
kernel: _linux-qcom-6.18
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0
persist-credentials: false

- name: Run lava-test-plans
uses: ./.github/actions/lava-test-plans
Expand All @@ -60,9 +61,10 @@ jobs:
outputs:
jobmatrix: ${{ steps.listjobs.outputs.jobmatrix }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0
persist-credentials: false

- name: "List jobs"
id: listjobs
Expand Down Expand Up @@ -99,7 +101,7 @@ jobs:
save_result_as_artifact: true
save_job_details: true
result_file_name: "${{ matrix.target.result_file }}"
- uses: mwasilew/github-action-matrix-outputs-write@v2
- uses: mwasilew/github-action-matrix-outputs-write@f7202d2224ebed937f287a2e2813e47fddd12bc8 # v2
Copy link
Contributor

@ricardosalveti ricardosalveti Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwasilew can we move this one under qualcomm / qualcomm-linux / foundriesio?

Copy link
Contributor

@mwasilew mwasilew Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can. I think I started OSR for this. Let me check it and report back here. There is also a chance I will eliminate it when refactoring the test.yml workflow.

Copy link
Contributor

@mwasilew mwasilew Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSR is still under review :(

Copy link

@steparce steparce Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As addressed in the OSR, we need @mwasilew to provide the correct Qualcomm organization as @ricardosalveti is stating there are a few options.
@mwasilew what organization will this move under (qualcomm / qualcomm-linux / foundriesio)? In addition, what will be the repo name?

if: always()
id: out
with:
Expand All @@ -116,7 +118,7 @@ jobs:
outputs:
boot_result: "${{ steps.print-boot-result.outputs.boot_result }}"
steps:
- uses: cloudposse/github-action-matrix-outputs-read@v1
- uses: cloudposse/github-action-matrix-outputs-read@33cac12fa9282a7230a418d859b93fdbc4f27b5a # v1
id: read
with:
matrix-step-name: "submit-boot-job"
Expand Down Expand Up @@ -165,9 +167,10 @@ jobs:
run: |
echo "${RESULT}"

- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0
persist-credentials: false

- name: Run lava-test-plans
uses: ./.github/actions/lava-test-plans
Expand All @@ -186,9 +189,10 @@ jobs:
outputs:
jobmatrix: ${{ steps.listjobs.outputs.jobmatrix }}
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0
persist-credentials: false

- name: "List jobs"
id: listjobs
Expand Down Expand Up @@ -240,9 +244,10 @@ jobs:
summary_id: ${{ steps.generate-summary.outputs.artifact_id }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0
persist-credentials: false

- name: Generate Summary
id: generate-summary
Expand Down
Loading