recipes-connectivity: add the qps615 ethernet driver#1698
recipes-connectivity: add the qps615 ethernet driver#1698ayaan-anwar wants to merge 1 commit intoqualcomm-linux:masterfrom
Conversation
Add the recipe and patches required to compile the QPS615 ethernet driver. Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
ayaan-anwar
requested review from
anujm1,
koenkooi,
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
|
Out-of-tree kernel modules go into recipes-kernel, recipes-connectivity is for userspace. |
| @@ -0,0 +1,37 @@ | |||
| inherit module | |||
There was a problem hiding this comment.
inherit below DESCRIPTION/SUMMARY/LICENSE
| @@ -0,0 +1,37 @@ | |||
| inherit module | |||
|
|
|||
| DESCRIPTION = "QPS615 Driver and Firmware" | |||
| git://github.com/TC956X/TC9564_Firmware.git;branch=industrial_limited_tested;protocol=https;name=firmware;destsuffix=firmware \ | ||
| " | ||
|
|
||
| # Separate the driver source and firmware when unpacking |
There was a problem hiding this comment.
SRCREV needs to go above where it's used, in this case SRC_URI
| " | ||
|
|
||
| # Separate the driver source and firmware when unpacking | ||
| SRCREV_source = "9faf7ea02e804f3ab86b21ea0e5d41ac40d37f91" |
There was a problem hiding this comment.
No version set in the filename, nor using PV.
| S = "${UNPACKDIR}/source" | ||
| B = "${S}/drivers/net/ethernet/toshiba/tc956x" | ||
|
|
||
| FILES:${PN} += "${base_libdir}/firmware/TC956X_Firmware_PCIeBridge.bin" |
There was a problem hiding this comment.
FILES* go below do_install()
| inherit module | ||
|
|
||
| DESCRIPTION = "QPS615 Driver and Firmware" | ||
| LICENSE = "GPL-2.0-only" |
There was a problem hiding this comment.
Since LICENSE gets transferred to the runtime packages, what license are the firmware files?
There was a problem hiding this comment.
Firmware is not GPL, see https://github.com/TC956X/TC9564_Firmware/blob/master/LICENSE.
|
you added some important information in the Github PR, which is good, I would recommend adding that information directly in the commit message instead. |
| Overlay the Qualcomm Platform driver for handling SoC specific hardware | ||
| configuration. | ||
|
|
||
| Upstream-Status: Pending |
There was a problem hiding this comment.
Why is it Pending? Please classify all the patches correctly.
| FILES:${PN} += "${base_libdir}/firmware/TC956X_Firmware_PCIeBridge.bin" | ||
|
|
||
| # This package is designed to run exclusively on ARMv8 (aarch64) machines. | ||
| # Therefore, builds for other architectures are not necessary and are explicitly excluded. |
There was a problem hiding this comment.
Why? Does it have any issues?
| # Install the firmware to /lib/firmware | ||
| do_install:append() { | ||
| # Install firmware binary from the second repo | ||
| install -d ${D}${base_libdir}/firmware/ |
There was a problem hiding this comment.
${nonarch_base_libdir}/firmware/
| do_install:append() { | ||
| # Install firmware binary from the second repo | ||
| install -d ${D}${base_libdir}/firmware/ | ||
| install -m 0644 ${UNPACKDIR}/firmware/Bin/TC956X_Firmware_PCIeBridge.bin ${D}${base_libdir}/firmware/ |
There was a problem hiding this comment.
What is the licence for the firmware? If it's GPL v2 (as it's stated), please provide full sources for the firmware.
Please don't describe patch contents. Describe why is something required. |
5 participants
Add support for the QPS615 Ethernet out of tree DLKM by introducing a new recipes-connectivity/qps615 recipe along with the required driver and firmware patches.
The recipe pulls the Toshiba QPS615 driver and firmware sources and applies Qualcomm‑specific extensions and compatibility fixes to enable QPS615 on Qualcomm platforms.
Overview of Qualcomm-specific patches:
Patch 1: QCOM platform driver support
Patch 2: Persistent MAC address support
Patch 3: Linux Kernel 6.18 compatibility
Exception details: Until the QPS615 driver is upstreamed (third party ETA: end of 2026), an exception has been approved to include the driver as an out of tree DLKM (QLIJIRA-99).