Skip to content

rb3gen2-core-kit: declare TPM2 machine feature#1713

Open
khalidfaisal17 wants to merge 1 commit intoqualcomm-linux:masterfrom
khalidfaisal17:master
Open

rb3gen2-core-kit: declare TPM2 machine feature#1713
khalidfaisal17 wants to merge 1 commit intoqualcomm-linux:masterfrom
khalidfaisal17:master

Conversation

@khalidfaisal17
Copy link
Contributor

@khalidfaisal17 khalidfaisal17 commented Mar 9, 2026 •
edited
Loading

The rb3gen2 MACHINE configuration is updated to expose TPM2 capability through MACHINE_FEATURES. This allows the meta-security layer (and in particular meta-tpm) to correctly include TPM2 userspace components, kernel config fragments, and system integration units.

meta-security enablement was part of PR #1504

the build now automatically enables:

  • TPM2 userspace stack (tpm2-tss)
  • TPM2 tooling (tpm2-tools)
  • TPM2 resource manager integration
  • Associated kernel configuration fragments from meta-security
  • EFI/PCI dependencies required for TPM2 initialization paths

These features ensure proper TPM2 support on rb3gen2 platforms where a dTPM is exposed over SPI.

This change is specific to rb3gen2 and does not affect other machines.

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Test run workflow

Test jobs for commit 67d7ed6

Test qcs615-adp-air qcs6490 qcs8300 qcs9100 qcs9100-rb8 qrb2210-rb1
AudioRecord ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
BT_FW_KMD_Service ❌ fail ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
BT_ON_OFF ⚠️ skip ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
BT_SCAN ⚠️ skip ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
CPUFreq_Validation ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
DSP_AudioPD ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
Ethernet ⚠️ skip 🚫 ⚠️ skip ✅ pass ✅ pass ⚠️ skip
Interrupts ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
OpenCV ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
WiFi_Firmware_Driver ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
WiFi_OnOff ⚠️ skip ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
adsp_remoteproc ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
boot ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
cdsp_remoteproc ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ⚠️ skip
hotplug ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass
irq ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass ✅ pass

All jobs summary

Job ID Device State Health
157545 qrb2210-rb1 Finished Complete
157562 qcs6490 Finished Complete
157548 qcs6490 Finished Complete
157578 qrb2210-rb1 Finished Complete
157575 qcs9100-rb8 Finished Complete
157550 qcs9100 Finished Complete
157556 qcs6490 Finished Complete
157568 qcs9100 Finished Complete
157535 qrb2210-rb1 Finished Complete
157549 qcs9100-rb8 Finished Complete
157543 qcs8300 Finished Complete
157564 qcs9100-rb8 Finished Complete
157539 qcs9100-rb8 Finished Complete
157555 qcs615-adp-air Finished Complete
157557 qrb2210-rb1 Finished Complete
157546 qcs8300 Finished Complete
157531 qcs8300 Finished Complete
157541 qcs615-adp-air Finished Complete
157540 qcs8300 Finished Complete
157570 qcs6490 Finished Complete
157529 qcs9100 Finished Complete
157534 qcs9100-rb8 Finished Complete
157576 qcs8300 Finished Complete
157538 qcs615-adp-air Finished Complete
157563 qcs8300 Finished Incomplete
157547 qcs615-adp-air Finished Complete
157542 qcs9100 Finished Complete
157572 qcs9100 Finished Complete
157558 qrb2210-rb1 Finished Complete
157574 qrb2210-rb1 Finished Complete
157532 qcs6490 Finished Complete
157536 qcs6490 Finished Complete
157530 qrb2210-rb1 Finished Complete
157561 qcs8300 Finished Complete
157544 qcs9100-rb8 Finished Complete
157577 qcs615-adp-air Running Unknown
157559 qcs6490 Finished Complete
157533 qcs6490 Finished Complete
157571 qcs9100-rb8 Finished Complete
157573 qcs9100-rb8 Finished Complete
157551 qrb2210-rb1 Finished Complete
157567 qcs9100 Finished Complete
157569 qcs615-adp-air Finished Complete
157565 qcs615-adp-air Finished Complete
157560 qcs8300 Finished Complete
157566 qcs9100 Finished Complete
157552 qcs615-adp-air Finished Complete
157537 qcs9100 Finished Complete

@test-reporting-app
Copy link

test-reporting-app bot commented Mar 9, 2026

Test Results

   47 files  +   27    208 suites  +188   3h 34m 19s ⏱️ + 3h 7m 29s
   45 tests +   38     40 ✅ +   33   0 💤 ± 0  5 ❌ +5 
1 974 runs  +1 834  1 958 ✅ +1 818  10 💤 +10  6 ❌ +6 

For more details on these failures, see this check.

Results for commit 67d7ed6. ± Comparison against base commit ab74e2d.

lumag
lumag requested changes Mar 9, 2026
View reviewed changes
Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change allows

Don't describe the change. Start your commit message with the description of the issue.

@khalidfaisal17 khalidfaisal17 requested a review from lumag March 9, 2026 15:00
lumag
lumag requested changes Mar 9, 2026
View reviewed changes
Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow TPM-related packages to be conditionally included
by the distro for rb3gen2.

Where is the issue that you are solving?

@khalidfaisal17
Copy link
Contributor Author

khalidfaisal17 commented Mar 9, 2026

This change allows

Don't describe the change. Start your commit message with the description of the issue.

Allow TPM-related packages to be conditionally included
by the distro for rb3gen2.

Where is the issue that you are solving?

Hi @lumag ,
Thanks for feedback. I have updated the commit message.

The issue is that rb3gen2 currently does not expose the tpm2 MACHINE_FEATURE, which prevents the distro from
conditionally including TPM-related packages. This blocks enabling the TPM software stack for rb3gen2-based builds.

The updated commit message now reflects this and explains why adding the tpm2 feature is necessary.
Please let me know if you would like any further adjustments.

@quaresmajose
Copy link
Contributor

quaresmajose commented Mar 9, 2026

This change allows

Don't describe the change. Start your commit message with the description of the issue.

Allow TPM-related packages to be conditionally included
by the distro for rb3gen2.

Where is the issue that you are solving?

Hi @lumag , Thanks for feedback. I have updated the commit message.

The issue is that rb3gen2 currently does not expose the tpm2 MACHINE_FEATURE, which prevents the distro from conditionally including TPM-related packages. This blocks enabling the TPM software stack for rb3gen2-based builds.

The updated commit message now reflects this and explains why adding the tpm2 feature is necessary. Please let me know if you would like any further adjustments.

You probably forgot to update the commit.

@ricardosalveti
Copy link
Contributor

ricardosalveti commented Mar 9, 2026

The updated commit message now reflects this and explains why adding the tpm2 feature is necessary.
Please let me know if you would like any further adjustments.

You shouldn't say that this is needed in order to include packages, you should explain why you are extending the machine features, saying that tpm2 can be provided via fTPM or dTPM. If via fTPM, please say which boot firmware release implements this support.

@khalidfaisal17
Copy link
Contributor Author

khalidfaisal17 commented Mar 9, 2026

This change allows

Don't describe the change. Start your commit message with the description of the issue.

Allow TPM-related packages to be conditionally included
by the distro for rb3gen2.

Where is the issue that you are solving?

Hi @lumag , Thanks for feedback. I have updated the commit message.
The issue is that rb3gen2 currently does not expose the tpm2 MACHINE_FEATURE, which prevents the distro from conditionally including TPM-related packages. This blocks enabling the TPM software stack for rb3gen2-based builds.
The updated commit message now reflects this and explains why adding the tpm2 feature is necessary. Please let me know if you would like any further adjustments.

You probably forgot to update the commit.

Updated the comment.

@khalidfaisal17 khalidfaisal17 requested a review from lumag March 9, 2026 17:38
@lumag
Copy link
Contributor

lumag commented Mar 9, 2026

You probably forgot to update the commit.

Updated the comment.

Still didn't happen.

@khalidfaisal17
rb3gen2-core-kit: add tpm2 support via MACHINE_FEATURES
65ef262 
Enable tpm2 in MACHINE_FEATURES for rb3gen2 to allow meta-security and meta-tpm
layers to include TPM2 userspace stack, tools, and required kernel fragments.
This ensures proper initialization of the SPI-based TPM via UEFI on this platform.

Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lumag lumag lumag approved these changes

@vkraleti vkraleti Awaiting requested review from vkraleti vkraleti is a code owner

@ricardosalveti ricardosalveti Awaiting requested review from ricardosalveti ricardosalveti is a code owner

@sbanerjee-quic sbanerjee-quic Awaiting requested review from sbanerjee-quic sbanerjee-quic is a code owner

@ndechesne ndechesne Awaiting requested review from ndechesne ndechesne is a code owner

@anujm1 anujm1 Awaiting requested review from anujm1 anujm1 is a code owner

@koenkooi koenkooi Awaiting requested review from koenkooi koenkooi is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@khalidfaisal17 @quaresmajose @ricardosalveti @lumag