modemmanager: enable qrtr for ModemManager on QCOM devices#1722
modemmanager: enable qrtr for ModemManager on QCOM devices#1722asusmith-qti wants to merge 1 commit intoqualcomm-linux:masterfrom
Conversation
asusmith-qti
requested review from
anujm1,
koenkooi,
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
Why? Please include details in commit message. |
| @@ -0,0 +1,3 @@ | |||
| PACKAGECONFIG:remove = "mbim" | |||
| PACKAGECONFIG:append = " qrtr" | |||
| EXTRA_OEMESON:remove = "-Dqrtr=false" | |||
There was a problem hiding this comment.
This is not needed if qrtr is in PACKAGECONFIG. If recipe has a bug, please send fix to meta-oe.
There was a problem hiding this comment.
ModemManager supports multiple chipset vendors; this change is required only to enable support for QCOM modems. That the reason for adding bbappend.
There was a problem hiding this comment.
yeah the EXTRA_OEMESON:remove = "-Dqrtr=false" is not needed here but because it is hardcoded in the recipe it should be removed upstream in meta-oe. I sugest to spilt it to new commit and add the link of the patch send upstream so we can carry it until it is merged in meta-oe.
There was a problem hiding this comment.
Khem is quick to merge, so just submit it straight ahead and let it be merged before merging this PR.
| @@ -0,0 +1,3 @@ | |||
| PACKAGECONFIG:remove = "mbim" | |||
| PACKAGECONFIG:append = " qrtr" | |||
anujm1
left a comment
anujm1
left a comment
There was a problem hiding this comment.
Please add details and move this to dynamic-layers
asusmith-qti
force-pushed
the
enable_qrtr
branch
from
4d00246 to
62da583
Compare
ModemManager requires QRTR to communicate with QCOM-based modems. Signed-off-by: Akula Susmitha <asusmith@qti.qualcomm.com>
asusmith-qti
force-pushed
the
enable_qrtr
branch
from
62da583 to
b24aec1
Compare
asusmith-qti
changed the title
Added info in commit msg. |
Currently changes were made in same folder |
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
- Which products use modems?
- This is not enough to enable the modem, the fcc unlock script should either be documented somewhere or enabled by the layer.
| @@ -0,0 +1,3 @@ | |||
| PACKAGECONFIG:remove:qcom = "mbim" | |||
There was a problem hiding this comment.
Why? You are disabling a feature, which might be in use by somebody else.
| @@ -0,0 +1,3 @@ | |||
| PACKAGECONFIG:remove:qcom = "mbim" | |||
| PACKAGECONFIG:append:qcom = " qrtr" | |||
| EXTRA_OEMESON:remove:qcom = "-Dqrtr=false" | |||
There was a problem hiding this comment.
Should not be necessary with the PACKAGECONFIG in place. Please fix it upstream.
4 participants
Enable the qrtr support in modemmanager and disable mbim.