uki: add back support for console and KERNEL_CMDLINE_EXTRA in the kernel cmdline #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default console entry was removed as part of the switch to the oe-core uki.bbclass, add it back. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
ricardosalveti
requested review from
ndechesne,
sbanerjee-quic and
vkraleti
as code owners
Contributor
Author
|
Console might be ok to be removed, but would need to be validated with all targets (and different kernel recipes). KERNEL_CMDLINE_EXTRA is actually used by rb1. |
lumag
reviewed
May 9, 2025
KERNEL_CMDLINE_EXTRA addition to the kernel command line was removed as part of the switch to the oe-core uki.bbclass, add it back. Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
vkraleti
approved these changes
May 9, 2025
lumag
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both were removed as a side effect of #722