Improve firmware packaging #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop DSP_QCOM_BASE_PATH and DSP_QCOM_PATH, two variables used only for Google Pixel firmware repackaging. Signed-off-by: Dmitry Baryshkov <[email protected]>
Specify S to be the actual source dir where we have unpacked all the binaries instead of being a random location. The change to the dragoboard410c recipe is required in order to silent the warning regarding the slash at the end of the S and B values. Signed-off-by: Dmitry Baryshkov <[email protected]>
With the S variable having correct value there is no need to specify full path in the LIC_FILES_CHKSUM. Signed-off-by: Dmitry Baryshkov <[email protected]>
QCS9100 and similar SoCs have two compute DSPs and also provide General Purpose DSPs. Make firmware-qcom.inc handle those firmware file names too. Signed-off-by: Dmitry Baryshkov <[email protected]>
In order to simplify handling and updating of the firmware, split common parts away from version-specific parts. Signed-off-by: Dmitry Baryshkov <[email protected]>
In order to simplify handling and updating of the firmware, split common parts away from version-specific parts. Signed-off-by: Dmitry Baryshkov <[email protected]>
In order to simplify handling and updating of the firmware, split common parts away from version-specific parts. Signed-off-by: Dmitry Baryshkov <[email protected]>
lumag
requested review from
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
Contributor
Author
|
This is a split from #852 |
Test jobs for commit f3c7425 |
koenkooi
approved these changes
May 15, 2025
Contributor
koenkooi
left a comment
koenkooi
left a comment
There was a problem hiding this comment.
The changes are straightforward and look good to me.
vkraleti
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify handling of board-specific firmware in preparation to handling tip versions of the firmware.