Qemu test expect failure output #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we will throw away the result immediately after the test, there is no need for guest disk flushes to actually make it to host disk, so make write caching unsafe to improve performance just like debos does. Signed-off-by: Robie Basak <[email protected]>
If the test times out or fails in CI, then it would be useful to see everything that was output so that we can either fix a bug or adjust our expect script. Asking pexpect to write to stdout works well for this as pytest captures test output and only prints it on individual test failure. Signed-off-by: Robie Basak <[email protected]>
basak-qcom
force-pushed
the
qemu-test-expect-failure-output
branch
from
14434b7 to
332f6c6
Compare
Test jobs for commit 332f6c6 |
Contributor
|
@basak-qcom I don't see any console output in the build log; I was expecting to see the qemu boot log there? |
Contributor
Author
|
This is deliberate. Output is only produced on a test failure. |
lool
approved these changes
Oct 7, 2025
Contributor
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
Cool, looks innoculous enough then; thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.