Skip to content

Conversation

@lool
Copy link
Contributor

@lool lool commented Apr 30, 2025

Fix a typo testing whether there is a local config fragment. This is
nasty in that it won't fail even under set -e as it's under an if
statement.

Fix a typo testing whether there is a local config fragment. This is
nasty in that it won't fail even under `set -e` as it's under an if
statement.

Signed-off-by: Loïc Minier <[email protected]>
@lool
Copy link
Contributor Author

lool commented Apr 30, 2025

I will look at adding shellcheck tests to prevent this in the future; shellcheck currently reports:

% shellcheck scripts/*

In scripts/build-linux-deb.sh line 77:
if [ -r kernel/configs/local.config]; then
^-- SC1009 (info): The mentioned syntax error was in this if expression.
   ^-- SC1073 (error): Couldn't parse this test expression. Fix to allow more checks.
        ^-- SC1019 (error): Expected this to be an argument to the unary condition.
                                    ^-- SC1020 (error): You need a space before the ].
                                    ^-- SC1072 (error): Missing space before ]. Fix any mentioned problems and try again.


In scripts/build-u-boot-rb1.sh line 75:
make -j`nproc` \
       ^-----^ SC2046 (warning): Quote this to prevent word splitting.
       ^-----^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`.

Did you mean:
make -j$(nproc) \

For more information:
  https://www.shellcheck.net/wiki/SC1020 -- You need a space before the ].
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of le...

and would have caught that; note that bash -n didn't see anything:

% bash -n scripts/*

@lool
Copy link
Contributor Author

lool commented Apr 30, 2025

I'm going to self-approve this to reroll a kernel and unbreak the image builds – currently all images fail to boot because the kernel is built without CONFIG_EFI_ZBOOT.

@lool lool merged commit ee2c2b3 into qualcomm-linux:main Apr 30, 2025
3 checks passed
@lool lool deleted the fix-kernel-config-usage branch May 28, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant