Move debos build into separate workflow file #36
Conversation
mattface
force-pushed
the
move-debos-build-logic
branch
2 times, most recently
from
ea0f675 to
24bce32
Compare
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
I did a quick first pass, I think it's smart to land the splitting of workflows first; I see the value of this to make the changes more digestable, and I think that applies to the security/architecture topics on how it all fits together.
I'd very much like for the permissions, input/output, upload/download, triggers etc. to make sense at every step.
.github/workflows/daily.yml
Outdated
|
|
||
| permissions: | ||
| checks: write | ||
| pull-requests: write |
.github/workflows/build-on-pr.yml
Outdated
| packages: read | ||
|
|
||
| jobs: | ||
| event-file: |
There was a problem hiding this comment.
I find it weird to upload the event-file without using it anywhere, let's perhaps defer this part to the next PR?
.github/workflows/build-on-pr.yml
Outdated
|
|
||
| permissions: | ||
| checks: write | ||
| pull-requests: write |
mattface
force-pushed
the
move-debos-build-logic
branch
from
341cfda to
37e90b3
Compare
|
I believe all comments should now be resolved |
Looking good, just the remaining comment "on: push" – do think we have this for meta-qcom too. (Did you have specific thoughts on limiting or not limiting the branches?) |
Start moving the build logic into separated files to copy the method of meta-qcom to run PR builds/tests with repo secrets. Signed-off-by: Matt Hart <[email protected]>
mattface
force-pushed
the
move-debos-build-logic
branch
from
37e90b3 to
fee0f00
Compare
|
Merging this now, we can always tweak / consolidate the build yaml files in later pull requests |
2 participants
Start moving the build logic into separated files to copy the method of meta-qcom to run PR builds/tests with repo secrets.