ci: Move to new artifact upload action #44
Conversation
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
I guess this is a draft PR as I see some DEBUG entries in it still?
.github/workflows/debos.yml
Outdated
| with: | ||
| path: /tmp/${BUILD_ID} | ||
| build_id: "${{ github.repository }}-${{ github.run_id }}-${{ github.run_attempt }}" | ||
| github_token: "${{ secrets.GITHUB_TOKEN }}" |
There was a problem hiding this comment.
I'm surprised you need to pass this specifically in the yaml; isn't GITHUB_TOKEN provided to actions by default?
There was a problem hiding this comment.
Its a security thing. GitHub doesn't want you to accidentally share the token with a workflow you haven't explicitly granted permissions to.
There was a problem hiding this comment.
Is is possible to implement an action like the github upload-artifact action, without passing the token? Does that require some lengthy certification process with github or something?
There was a problem hiding this comment.
I've come up with a better way. Its slight complicated to get going but will actually work much better and get us working just like the public action. I'll redo this PR once I get it working
.github/workflows/debos.yml
Outdated
| uses: qualcomm-linux/upload-private-artifact-action@v1 | ||
| with: | ||
| path: /tmp/${BUILD_ID} | ||
| build_id: "${{ github.repository }}-${{ github.run_id }}-${{ github.run_attempt }}" |
There was a problem hiding this comment.
This is more some thoughts on the API of this action, but I wonder if we should keep the concept of a build_id local to the repositories that needs one.
As an user of such an action, I would expect it to provide similar behavior as actions/upload-artifact. In particular, I expect that the artifacts uploaded from one repo are stored in a repo specific collection of artifacts.
When using upload-artifact, most parameters are optional. Perhaps our upload-private-artifact could provide similar behavior and there would be a download action to easily retrieve a particular artifact or the latest artifact with some name (like we're doing in the debos recipe to fetch u-boot/linux builds prior to building an image).
.github/workflows/debos.yml
Outdated
| - /efs/qli/metaqcom/gh-runners/quic-yocto/downloads:/fileserver-downloads | ||
| options: --privileged | ||
| steps: | ||
| - name: TMP-DEBUG |
There was a problem hiding this comment.
I'm guessing this is going away in the final version?
doanac
changed the title
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
I think this is really looking really nice now, from the perspective of this repository!
doanac
force-pushed
the
upload-action
branch
6 times, most recently
from
385c429 to
19e83f1
Compare
Signed-off-by: Andy Doan <[email protected]>
doanac
changed the title
|
Okay - i've cleaned up the action and backend code in a way to make this work fairly cleanly |
|
I liked all the removals in the latest version :) |
|
I think this is ready if you are satisfied. It turned into way more backend work than I was ever wanting to do for this but it should make the transition work for other repos go more smoothly as we get them on the new runners. |
3 participants
No description provided.