workflows: Fix updating symlinks to directories #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating symlink to directories requires an extra flag to ln. Without the flag, if a symlink already exists and points to a directory, a new symlink is created under that directory instead of updating the symlink. Signed-off-by: Loïc Minier <[email protected]>
Test Results 1 files 2 suites 2m 59s ⏱️ Results for commit d4bf209. |
Test jobs for commit d4bf209 |
ricardosalveti
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In weekly workflows, we upload new builds to their own directory and
then update a symlink pointing to the latest one. The symlink update
logic is currently broken.
Updating symlink to directories requires an extra flag to ln. Without
the flag, if a symlink already exists and points to a directory, a new
symlink is created under that directory instead of updating the symlink.
This is not attempting to fix the leftover symlinks on the fileserver
side, these will be garbage collected over time.