-
Notifications
You must be signed in to change notification settings - Fork 20
Initial version of overlay to build Debian packages #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fbb3e51 to
55936f7
Compare
|
@ricardosalveti @ndechesne This is an initial version with debdiff in the same repo; here are sample runs for hello-world on arm64 and amd64 (takes about 4mn to build): If this approach looks alright, I'd like to land this them I'll provide a pull request to integrate these builds in the image (in the meantime we can test builds privately). As I write this, there's currently a larger test build of mesa running which I expect will take a while: |
67bfce2 to
9d11c26
Compare
e4860b2 to
ad430d3
Compare
obbardc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me for building independent debian packages which don't need reverse/inter-dependencies built as well. I guess once you move to something more complex than that you'll need something like OBS to handle interdependent packages :-)
Haha appreciate @obbardc :) I do have plans to build a bit better infrastructure indeed! |
basak-qcom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the quality of this PR in terms of separated single-purpose commits and commit messages!
This looks good in terms of approach.
I think this is good enough to land now, but have some minor comments and suggestions in case you'd like to incorporate them (now or in the future).
Expects a yaml file such as: dsc_url: "https://snapshot.debian.org/archive/debian/20250416T143525Z/pool/main/h/hello/hello_2.10-5.dsc" dsc_sha256sum: "319f8c377eb48597798b699f72ab853f3439a991583ddd51bf94b415373ffdfe" debdiff_file: "hello_2.10-5qcom1.debdiff" suite: "trixie" Signed-off-by: Loïc Minier <[email protected]>
This modified hello-world package should fail to build during make check. Signed-off-by: Loïc Minier <[email protected]>
Signed-off-by: Loïc Minier <[email protected]>
Signed-off-by: Loïc Minier <[email protected]>
This should not be shipped as trixie will likely track 25.0.x. Signed-off-by: Loïc Minier <[email protected]>
Pass the path to a yaml config file. Signed-off-by: Loïc Minier <[email protected]>
|
I've addressed the proposed syntax improvement for tempfile creation/cleanup, and in the process also removed the leftover debug logic not to remove the tmpfile dir, so if CI passes I will merge this. Thanks @obbardc and @basak-qcom for your review! |
This is an initial version with a few light samples:
The general approach is to commit a yaml file pointing at the original .dsc with its sha256sum, plus an optional debdiff. This gets build through sbuild and uploaded to our usual fileserver.
NB: I initially had a cache of the sbuild chroot, but seeing that it only takes 1mn to build, I thought it wasn't worth the hassle.