Skip to content

Conversation

@lool
Copy link
Contributor

@lool lool commented May 29, 2025

This is an initial version with a few light samples:

  • scripts: Add build-deb to build a Debian package
  • overlay-debs: Initial version with sample
  • overlay-debs: Add unmodified and working sample
  • workflows: New build-overlay-deb workflow

The general approach is to commit a yaml file pointing at the original .dsc with its sha256sum, plus an optional debdiff. This gets build through sbuild and uploaded to our usual fileserver.

NB: I initially had a cache of the sbuild chroot, but seeing that it only takes 1mn to build, I thought it wasn't worth the hassle.

@lool lool force-pushed the pkg-builds branch 2 times, most recently from fbb3e51 to 55936f7 Compare May 29, 2025 16:49
@lool
Copy link
Contributor Author

lool commented May 29, 2025

@ricardosalveti @ndechesne This is an initial version with debdiff in the same repo; here are sample runs for hello-world on arm64 and amd64 (takes about 4mn to build):
https://github.com/qualcomm-linux/qcom-deb-images/actions/runs/15328496408/job/43129055300?pr=64
https://github.com/qualcomm-linux/qcom-deb-images/actions/runs/15328496408/job/43129055304?pr=64

If this approach looks alright, I'd like to land this them I'll provide a pull request to integrate these builds in the image (in the meantime we can test builds privately).

As I write this, there's currently a larger test build of mesa running which I expect will take a while:
https://github.com/qualcomm-linux/qcom-deb-images/actions/runs/15328956796/job/43130641135
https://github.com/qualcomm-linux/qcom-deb-images/actions/runs/15328956796/job/43130641103

@lool lool force-pushed the pkg-builds branch 2 times, most recently from 67bfce2 to 9d11c26 Compare May 29, 2025 18:00
@lool lool mentioned this pull request May 29, 2025
@lool lool force-pushed the pkg-builds branch 5 times, most recently from e4860b2 to ad430d3 Compare May 29, 2025 19:05
Copy link

@obbardc obbardc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me for building independent debian packages which don't need reverse/inter-dependencies built as well. I guess once you move to something more complex than that you'll need something like OBS to handle interdependent packages :-)

@lool lool marked this pull request as ready for review June 3, 2025 13:19
@lool
Copy link
Contributor Author

lool commented Jun 3, 2025

This looks OK to me for building independent debian packages which don't need reverse/inter-dependencies built as well. I guess once you move to something more complex than that you'll need something like OBS to handle interdependent packages :-)

Haha appreciate @obbardc :) I do have plans to build a bit better infrastructure indeed!

Copy link
Contributor

@basak-qcom basak-qcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the quality of this PR in terms of separated single-purpose commits and commit messages!

This looks good in terms of approach.

I think this is good enough to land now, but have some minor comments and suggestions in case you'd like to incorporate them (now or in the future).

lool added 6 commits June 5, 2025 10:26
Expects a yaml file such as:

dsc_url: "https://snapshot.debian.org/archive/debian/20250416T143525Z/pool/main/h/hello/hello_2.10-5.dsc"
dsc_sha256sum: "319f8c377eb48597798b699f72ab853f3439a991583ddd51bf94b415373ffdfe"
debdiff_file: "hello_2.10-5qcom1.debdiff"
suite: "trixie"

Signed-off-by: Loïc Minier <[email protected]>
This modified hello-world package should fail to build during make check.

Signed-off-by: Loïc Minier <[email protected]>
This should not be shipped as trixie will likely track 25.0.x.

Signed-off-by: Loïc Minier <[email protected]>
Pass the path to a yaml config file.

Signed-off-by: Loïc Minier <[email protected]>
@lool
Copy link
Contributor Author

lool commented Jun 5, 2025

I've addressed the proposed syntax improvement for tempfile creation/cleanup, and in the process also removed the leftover debug logic not to remove the tmpfile dir, so if CI passes I will merge this. Thanks @obbardc and @basak-qcom for your review!

@lool lool merged commit 523802c into qualcomm-linux:main Jun 5, 2025
8 checks passed
@lool lool deleted the pkg-builds branch June 5, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants